Github user priyankagargnitk commented on the issue:
https://github.com/apache/spark/pull/15609
Sure.. I am closing it... If still face any issues... will raise another..
Thanks for the help.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15609
@priyankagargnitk Could maybe we then close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user priyankagargnitk commented on the issue:
https://github.com/apache/spark/pull/15609
Hmm... I think that makes sense.. i am trying a couple of more things...
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15609
@priyankagargnitk the use case you are describing is not supported, and I
don't think we should merge this. You can just call type coercion rules on your
expression tree, to get the properly type
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15609
@priyankagargnitk this should be covered in type widening. The `trueValue`
and `falseValue` expressions should have the same type by the time we reach the
execution phase. The `IfCoercion` rule s
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15609
Then, wouldn't the responsibility of type coercion be your own layer? I
guess this PR virtually mean every expression handled in `TypeCoercion` should
be fixed too. For example, I guess
Github user priyankagargnitk commented on the issue:
https://github.com/apache/spark/pull/15609
Actually our use case is little different, we are not invoking it with the
Select queries.. We are using JS to let user type expressions and then we have
created out own layer on top of spa
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15609
@priyankagargnitk Could I please ask some codes which I can reproduce this
issue? It seems fine the sql below:
```sql
spark-sql> SELECT if(true, cast('2014-01-01' as date), cast('201
Github user priyankagargnitk commented on the issue:
https://github.com/apache/spark/pull/15609
actually, its not covered in type widening... So, if any of my expression
is calling if expression ( in nested) .. its failing because of this issue.
---
If your project is set up for it,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15609
Hm, does this cause a actual problem? I thought this is covered in
type-widening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15609
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
11 matches
Mail list logo
