[GitHub] spark issue #15648: [SPARK-18119][SPARK-CORE] Namenode safemode check is onl...

2016-11-28 Thread liuml07
Github user liuml07 commented on the issue: https://github.com/apache/spark/pull/15648 Sorry for coming late. The change is very reasonable. Glad it's merged. Steve: > Where my knowledge of HDFS-HA fails is what happens then; Does the RPC client try another NN? Or just it

[GitHub] spark issue #15648: [SPARK-18119][SPARK-CORE] Namenode safemode check is onl...

2016-11-25 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15648 Merged to master/2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #15648: [SPARK-18119][SPARK-CORE] Namenode safemode check is onl...

2016-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15648 **[Test build #3437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3437/consoleFull)** for PR 15648 at commit

[GitHub] spark issue #15648: [SPARK-18119][SPARK-CORE] Namenode safemode check is onl...

2016-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15648 **[Test build #3437 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3437/consoleFull)** for PR 15648 at commit

[GitHub] spark issue #15648: [SPARK-18119][SPARK-CORE] Namenode safemode check is onl...

2016-11-24 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/15648 LGTM, as the javadocs say *If true check only for Active NNs status, else check first NN's status*. But I don't know enough about HDFS HA to be It'll check the first NN, if that is

[GitHub] spark issue #15648: [SPARK-18119][SPARK-CORE] Namenode safemode check is onl...

2016-11-24 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15648 CC @steveloughran who may also have good insight into whether this it the right change for HDFS HA. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #15648: [SPARK-18119][SPARK-CORE] Namenode safemode check is onl...

2016-11-22 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15648 HDFS folks internally indicated this is likely the right change. Let's leave it for a bit before committing. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #15648: [SPARK-18119][SPARK-CORE] Namenode safemode check is onl...

2016-11-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/15648 @srowen I'm actually not 100% sure what should happen with hdfs HA -- lemme ask around. This looks right but worth checking that we're not covering up some other cluster issue. --- If your

[GitHub] spark issue #15648: [SPARK-18119][SPARK-CORE] Namenode safemode check is onl...

2016-11-21 Thread ashangit
Github user ashangit commented on the issue: https://github.com/apache/spark/pull/15648 @holdenk and @srowen any news? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15648: [SPARK-18119][SPARK-CORE] Namenode safemode check is onl...

2016-11-07 Thread ashangit
Github user ashangit commented on the issue: https://github.com/apache/spark/pull/15648 Comments taken in account. For the test it is in fact a really simple change but let me know if we have to add a it. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #15648: [SPARK-18119][SPARK-CORE] Namenode safemode check is onl...

2016-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15648 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this