[GitHub] spark issue #15652: [SPARK-16987] [None] Add spark-default.conf property to ...

2017-05-11 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15652 I added this with #16625, this PR is not needed anymore. Please close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15652: [SPARK-16987] [None] Add spark-default.conf property to ...

2017-05-11 Thread chie8842
Github user chie8842 commented on the issue: https://github.com/apache/spark/pull/15652 @HyukjinKwon I'm sorry, I haven't reply for a long time. I'll check it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15652: [SPARK-16987] [None] Add spark-default.conf property to ...

2017-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15652 Hi @chie8842, is it still active? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15652: [SPARK-16987] [None] Add spark-default.conf property to ...

2016-11-19 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15652 Aside from me not liking the API change you're introducing, you need to add a unit test to make sure the feature is working. I suggest taking the scenario I described in a previous comment

[GitHub] spark issue #15652: [SPARK-16987] [None] Add spark-default.conf property to ...

2016-11-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15652 OK, I wouldn't mind getting @vanzin to glance at this as it involves SSL. (Can you also replace [None] with [WEBUI] in the title?) Looks fairly straightforward to me. --- If your

[GitHub] spark issue #15652: [SPARK-16987] [None] Add spark-default.conf property to ...

2016-11-09 Thread hayashidac
Github user hayashidac commented on the issue: https://github.com/apache/spark/pull/15652 I reflected some comments. And I handled about trivial issues in ml library. Is it OK to contain them in this PR? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #15652: [SPARK-16987] [None] Add spark-default.conf property to ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15652 **[Test build #3409 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3409/consoleFull)** for PR 15652 at commit

[GitHub] spark issue #15652: [SPARK-16987] [None] Add spark-default.conf property to ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15652 **[Test build #3409 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3409/consoleFull)** for PR 15652 at commit

[GitHub] spark issue #15652: [SPARK-16987] [None] Add spark-default.conf property to ...

2016-10-27 Thread hayashidac
Github user hayashidac commented on the issue: https://github.com/apache/spark/pull/15652 Thank you very much. I fixed for your comment. Please check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15652: [SPARK-16987] [None] Add spark-default.conf property to ...

2016-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15652 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this