[GitHub] spark issue #15687: Update SparkPi.scala

2016-11-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15687 There's one more in `LocalPi.scala` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15687: Update SparkPi.scala

2016-11-01 Thread mrydzy
Github user mrydzy commented on the issue: https://github.com/apache/spark/pull/15687 Thank you Sean! I've updated Scala, Java and Python examples and changed the commit name as you've requested. I can't seem to find the fourth example though. --- If your project is set up for it, y

[GitHub] spark issue #15687: Update SparkPi.scala

2016-11-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15687 There are actually 4 instances of the Pi example. I'll merge it if you update them all, just for reasons of clarity, sure. If you would update the title to something like `[MINOR] Use <= for clarity

[GitHub] spark issue #15687: Update SparkPi.scala

2016-11-01 Thread mrydzy
Github user mrydzy commented on the issue: https://github.com/apache/spark/pull/15687 It was exactly 7/10. Realising '<=' made the concept clearer to me (as I'm a beginner following examples), but it might be it's just me, so I'm not insisting. 2016-11-01 10:40 GMT+01:

[GitHub] spark issue #15687: Update SparkPi.scala

2016-11-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15687 Out of curiosity do you remember how many times one was bigger than the other? if it was 10/10 then you probably have a point, and that there's something about the way the example actually executes t

[GitHub] spark issue #15687: Update SparkPi.scala

2016-10-30 Thread mrydzy
Github user mrydzy commented on the issue: https://github.com/apache/spark/pull/15687 Hey, Thanks for reply! The results I got are really small and could be due to chance. The reason why I brought it up, is because I found that confusing while following the example, but you're

[GitHub] spark issue #15687: Update SparkPi.scala

2016-10-30 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15687 In theory, it doesn't matter because the circumference has 0 width, but in practice it could matter a very very small bit because of floating-point round-off. It doesn't really matter for purposes of

[GitHub] spark issue #15687: Update SparkPi.scala

2016-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15687 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat