Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Thank you for review and merging, @srowen , @gatorsmile , and @rxin .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15789
Merged to master/2.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Thank you, @srowen !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15789
I'll merge if there are no further comments. To restate -- basically the
test helper function returns a path that is perfectly fine for reading test
data, and is flexible because it doesn't depend on
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Hi, @rxin .
Yep. The actual issue is the current code generates the new golden files in
the following folder. So, we cannot identify which file is changed and cannot
commit the newly
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15789
Can you explain what the actual issue is? I read the description and still
have no idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Thank you, @srowen !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Thank you, @srowen and @gatorsmile .
I replied the comment.
For `java.nio.file.Paths.get("src", "test", "resources",
"sqlgen").toFile.getCanonicalPath`, could you give me advice again
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Thank you, @srowen and @gatorsmile .
I replied those two comments.
For `java.nio.file.Paths.get("src", "test", "resources",
"sqlgen").toFile.getCanonicalPath`, I was a little bit confu
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15789
LGTM except a comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15789
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15789
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68237/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15789
**[Test build #68237 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68237/consoleFull)**
for PR 15789 at commit
[`bd7258d`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15789
**[Test build #68237 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68237/consoleFull)**
for PR 15789 at commit
[`bd7258d`](https://github.com/apache/spark/commit/b
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
There occurs four `randomized aggregation test`s failures due to
`OutOfMemoryError`. But, it seems to be irrelevant. I'll wait the next test
running currently.
```
[info] - randomized
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15789
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15789
**[Test build #68232 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68232/consoleFull)**
for PR 15789 at commit
[`725cd45`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15789
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68232/
Test FAILed.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15789
**[Test build #68233 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68233/consoleFull)**
for PR 15789 at commit
[`bd7258d`](https://github.com/apache/spark/commit/b
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
It's fixed like `SQLQueryTestSuite`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Oh, you mean the the following. I'll fix this PR again. Sorry, @gatorsmile .
```scala
private val baseResourcePath = {
// If regenerateGoldenFiles is true, we must be runn
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15789
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15789
**[Test build #68232 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68232/consoleFull)**
for PR 15789 at commit
[`725cd45`](https://github.com/apache/spark/commit/7
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Hi, @gatorsmile .
I create a PR for `LogicalPlanToSQLSuite` part from #15546 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15789
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68233/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15789
**[Test build #68233 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68233/consoleFull)**
for PR 15789 at commit
[`bd7258d`](https://github.com/apache/spark/commit/
30 matches
Mail list logo
