Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15837
Close this as alternative one #16659 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15837
I'm worried about performance, now we have an extra function call and a if
branch to retrieve the result of common subexpressions. Maybe we should just
disable subexpression elimination for branch
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15837
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15837
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71240/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15837
**[Test build #71240 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71240/testReport)**
for PR 15837 at commit
[`9197cd9`](https://github.com/apache/spark/commit/9
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15837
ping @cloud-fan Since 2.1 is released now, can you have time to review
this? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15837
@kiszk I am hesitant to set a threshold for that. One reason is it will
increase the complexity of subexpression elimination implementation and the
benefit can be low or uncertain. Another reason is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15837
**[Test build #71240 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71240/testReport)**
for PR 15837 at commit
[`9197cd9`](https://github.com/apache/spark/commit/91
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/15837
IMHO, it would be good to stop applying subexpression elimination to a very
simple expression (e.g. `Literal(1))`). This is because it takes some cost
(e.g. executing a conditional branch) for this su
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15837
@kiszk Do you mean to avoid subexpression elimination?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15837
@cloud-fan Sure, no problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15837
Sorry for the delay, but I may not have time to review it before the 2.1
release, can you hold it off until 2.1 release? thanks!
---
If your project is set up for it, you can reply to this email
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/15837
Sorry for being late while I was travelling.
Can we introduce a configurable threshold parameter to avoid an application
of this elimination to a very simple expression (e.g. `Literal(1)`)?
---
I
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15837
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68967/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15837
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15837
**[Test build #68967 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68967/consoleFull)**
for PR 15837 at commit
[`f95100b`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15837
**[Test build #68967 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68967/consoleFull)**
for PR 15837 at commit
[`f95100b`](https://github.com/apache/spark/commit/f
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15837
re-ping @cloud-fan @kiszk @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15837
ping @cloud-fan @hvanhovell @kiszk Can you help review this? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15837
ping @cloud-fan @hvanhovell @kiszk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15837
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68455/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15837
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15837
**[Test build #68455 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68455/consoleFull)**
for PR 15837 at commit
[`3ae70e8`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15837
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15837
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68452/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15837
**[Test build #68452 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68452/consoleFull)**
for PR 15837 at commit
[`3274e91`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15837
**[Test build #68455 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68455/consoleFull)**
for PR 15837 at commit
[`3ae70e8`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15837
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15837
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68450/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15837
**[Test build #68450 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68450/consoleFull)**
for PR 15837 at commit
[`63accf8`](https://github.com/apache/spark/commit/
30 matches
Mail list logo
