[GitHub] spark issue #15905: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vector...

2016-11-17 Thread AnthonyTruchet
Github user AnthonyTruchet commented on the issue: https://github.com/apache/spark/pull/15905 I missed part of my company guidelines. Closing this PR and creating a new one shortly from my company account. Sorry for the noise. --- If your project is set up for it, you can reply to

[GitHub] spark issue #15905: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vector...

2016-11-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15905 I personally think it's good to be consistent. I think it's more readable to break out these function definitions, and, it seems like there's evidence it might avoid some unintended objects in a

[GitHub] spark issue #15905: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vector...

2016-11-17 Thread AnthonyTruchet
Github user AnthonyTruchet commented on the issue: https://github.com/apache/spark/pull/15905 By he way do you think that this should be addressed in core or just in each ML specific use ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #15905: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vector...

2016-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15905 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this