Github user sethah commented on the issue:
https://github.com/apache/spark/pull/16129
This LGTM. Now that I'm looking at it, the test suite **never actually
tests for correctness**, just basic input/output sizes. We really should have
better tests, but it's ok with me if it's done in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16129
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16129
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69709/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16129
**[Test build #69709 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69709/consoleFull)**
for PR 16129 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16129
**[Test build #69709 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69709/consoleFull)**
for PR 16129 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16129
> just paste in the new values
this seems like the reasonable approach. your intuition and explanation
make sense to me.
thanks @srowen
---
If your project is set up for
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16129
@felixcheung maybe you can advise me on this. I think this is a correct
fix, but ends up changing the results of decision forests a little bit. The
SparkR test you wrote fails:
```
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16129
**[Test build #3467 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3467/consoleFull)**
for PR 16129 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16129
**[Test build #3467 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3467/consoleFull)**
for PR 16129 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16129
**[Test build #3466 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3466/consoleFull)**
for PR 16129 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16129
**[Test build #3466 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3466/consoleFull)**
for PR 16129 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16129
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16129
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69618/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16129
**[Test build #69618 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69618/consoleFull)**
for PR 16129 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16129
**[Test build #69618 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69618/consoleFull)**
for PR 16129 at commit
15 matches
Mail list logo
