Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16148
Agreed. We will definitely keep that in mind but there is certainly a lot
going in working the API already.
---
If your project is set up for it, you can reply to this email and have
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16148
@felixcheung This is fine to merge since it is for docs/examples only. But
in general, we should be better about adding these right away after adding the
R APIs, rather than doing them all at
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16148
Yeah, 2.1 RC2 has been cut, but I think we still need to merge it into
branch-2.1, since it's possible we have new RC. Even if RC2 passed voting, we
will have 2.1.1, 2.1.2, ... which need this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69862/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69862 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69862/consoleFull)**
for PR 16148 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69862 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69862/consoleFull)**
for PR 16148 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16148
LGTM. Looks like we are locked down for 2.1. Good to have with all the new
examples but seems like a lot of code (example) changes?
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69842/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69842 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69842/consoleFull)**
for PR 16148 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69842 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69842/consoleFull)**
for PR 16148 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69799/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69799 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69799/consoleFull)**
for PR 16148 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69799 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69799/consoleFull)**
for PR 16148 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16148
A couple more comments, LGTM otherwise. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69721/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69721 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69721/consoleFull)**
for PR 16148 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69721 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69721/consoleFull)**
for PR 16148 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69717/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69717 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69717/consoleFull)**
for PR 16148 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16148
Yeah, I have the same concerns, so we should push forward SPARK-12347 and
it should not be very hard to do that.
---
If your project is set up for it, you can reply to this email and have your
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16148
hmm, yea, I suspect these example can be easily forgotten while changes are
made - they could end up getting out of sync easily
---
If your project is set up for it, you can reply to this
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16148
@felixcheung That's a good question. We don't run all MLlib examples for
testing until [SPARK-12347](https://issues.apache.org/jira/browse/SPARK-12347)
was resolved.
---
If your project is set
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69717 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69717/consoleFull)**
for PR 16148 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16148
this is great, thanks! btw, how are these examples getting run? is there a
way to know if the examples are broken because of API changes?
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69673 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69673/consoleFull)**
for PR 16148 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69673/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16148
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16148
**[Test build #69673 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69673/consoleFull)**
for PR 16148 at commit
33 matches
Mail list logo
