Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16233
@yhuai I was trying to do that yesterday and found that JIRA went something
wrong, will try again later today.
---
If your project is set up for it, you can reply to this email and have your
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/16233
@jiangxb1987 Once jira is back, let's create jiras to address follow-up
issues (probably you have already done that before jira went down).
---
If your project is set up for it, you can reply to
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16233
Merging to master. Please address the remaining comments in a follow-up.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/16233
left https://github.com/apache/spark/pull/16233/files#r95669988 and
https://github.com/apache/spark/pull/16233/files#r95662299. I think we need to
address them before we switch the code path to this
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16233
LGTM except two trivial comments:
https://github.com/apache/spark/pull/16233/files#r95313666
https://github.com/apache/spark/pull/16233/files#r95300580
BTW, please update the PR
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16233
LGTM except 2 comments:
https://github.com/apache/spark/pull/16233/files#r95514898 and
https://github.com/apache/spark/pull/16233/files#r95526238
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71200/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71200 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71200/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71200 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71200/testReport)**
for PR 16233 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71181/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71181 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71181/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71181 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71181/testReport)**
for PR 16233 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71161/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71161 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71161/testReport)**
for PR 16233 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71152/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71152 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71152/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71161 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71161/testReport)**
for PR 16233 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71146/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71146/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71152 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71152/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71146/testReport)**
for PR 16233 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16233
@gatorsmile Thank you for such a detailed review! I'll address them ASAP!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16233
I briefly went over the code. It looks good to me. After resolving the
above comments, I will go over the test case coverage.
---
If your project is set up for it, you can reply to this email
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16233
Sorry, I have not finished the review. Need to buy a milk for my baby. Will
continue the review soon. : )
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71057/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71057 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71057/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71057 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71057/testReport)**
for PR 16233 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16233
This looks good to me. cc @yhuai @cloud-fan @gatorsmile for final sign off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71044/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71044 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71044/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71044 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71044/testReport)**
for PR 16233 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71011/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71011 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71011/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71011 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71011/testReport)**
for PR 16233 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71008 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71008/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #71008 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71008/testReport)**
for PR 16233 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70800/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70806/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #70806 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70806/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #70800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70800/testReport)**
for PR 16233 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70757/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #70757 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70757/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #70757 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70757/testReport)**
for PR 16233 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70750/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #70750 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70750/testReport)**
for PR 16233 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70748/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16233
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #70748 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70748/testReport)**
for PR 16233 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #70750 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70750/testReport)**
for PR 16233 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16233
@hvanhovell I've added `AnalysisContext` to support resolve a view
references CTE/Windows.
@gatorsmile I'll try to improve the test cases next week, coz I plan to
make a short trip
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16233
**[Test build #70748 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70748/testReport)**
for PR 16233 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16233
Generally, the solution also looks ok to me. I think the test case coverage
needs to be improved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16233
Could you also add a test case for verifying the error behaviors?
For example, in the definition of a nested view, how Analyzer behaves when
the dependent databases, views, or views are
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16233
> Note this is compatible with the views defined by older versions of
Spark(before 2.2), which have empty defaultDatabase and all the relations in
viewText have database part defined.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16233
> 4. Add `AnalysisContext` to enable us to still support a view created
with CTE/Windows query.
What is the `AnalysisContext `?
---
If your project is set up for it, you can reply to
68 matches
Mail list logo
