[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-14 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16246 Ok, I am merging this to master/2.1/2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70110/ Test PASSed. ---

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #70110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70110/consoleFull)** for PR 16246 at commit [`0b6bfd4`](https://github.com/apache/spark/commit/

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #70110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70110/consoleFull)** for PR 16246 at commit [`0b6bfd4`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/16246 @hvanhovell, I really appreciate your time reviewing my code. I have addressed all your four comments. Thanks! --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16246 LGTM - pending jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70094/ Test PASSed. ---

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #70094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70094/consoleFull)** for PR 16246 at commit [`6040dcf`](https://github.com/apache/spark/commit/

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #70094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70094/consoleFull)** for PR 16246 at commit [`6040dcf`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16246 Sure, thanks! @nsyca --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/16246 I am working on the code based on @hvanhovell's proposal. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16246 @hvanhovell I like your ideas. : ) This JIRA is in the `Blocker` level of Spark 2.1. If we are doing a major refactoring in `CheckAnalysis `, is it too risky at the last minute? I am fin

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-12 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16246 I think we need to revisit the rule in CheckAnalysis, and make it `Alias` aware. We only need to keep track of the inner references. We traverse/recurse down the tree and do a few things: - W

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70025/ Test PASSed. ---

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #70025 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70025/consoleFull)** for PR 16246 at commit [`724335a`](https://github.com/apache/spark/commit/

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-12 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/16246 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70020/ Test FAILed. ---

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #70020 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70020/consoleFull)** for PR 16246 at commit [`f88a205`](https://github.com/apache/spark/commit/

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #70025 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70025/consoleFull)** for PR 16246 at commit [`724335a`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #70020 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70020/consoleFull)** for PR 16246 at commit [`f88a205`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-12 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/16246 Thank you, @gatorsmile, for your code review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16246 cc @hvanhovell @ericl --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69978/ Test PASSed. ---

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #69978 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69978/consoleFull)** for PR 16246 at commit [`09b543b`](https://github.com/apache/spark/commit/

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #69978 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69978/consoleFull)** for PR 16246 at commit [`09b543b`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16246 @nsyca Edit the PR description and move the investigation there. Then, when we merge the PR, it will be part of the commit description. --- If your project is set up for it, you can reply to thi

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/16246 This problem can be reproduced with a simple script now. scala Seq((1,1)).toDF("pk","pv").createOrReplaceTempView("p") Seq((1,1)).toDF("ck","cv").createOrReplaceTempView("c") sq

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16246 Do you what code changes caused the regression? In addition, could you post your investigation in the PR description? --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69968/ Test PASSed. ---

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #69968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69968/consoleFull)** for PR 16246 at commit [`b93b3ce`](https://github.com/apache/spark/commit/

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #69968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69968/consoleFull)** for PR 16246 at commit [`b93b3ce`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #69967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69967/consoleFull)** for PR 16246 at commit [`e871783`](https://github.com/apache/spark/commit/

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16246 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69967/ Test FAILed. ---

[GitHub] spark issue #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32

2016-12-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16246 **[Test build #69967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69967/consoleFull)** for PR 16246 at commit [`e871783`](https://github.com/apache/spark/commit/e