[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-05-17 Thread ramialbatal
Github user ramialbatal commented on the issue: https://github.com/apache/spark/pull/16377 Hi, I am using 2.1.0 on AWS, when fitting a CrossValidator of a pipeline of one Random Forest Stage I get `java.lang.UnsupportedOperationException: empty.max` knowing that I do not have any empt

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-24 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16377 Thanks @jkbradley! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-24 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16377 LGTM Thanks! Merging with master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #71877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71877/testReport)** for PR 16377 at commit [`750d27f`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71877/ Test PASSed. ---

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #71877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71877/testReport)** for PR 16377 at commit [`750d27f`](https://github.com/apache/spark/commit/75

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-23 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 @jkbradley thanks! I've updated the code based on your comments. Please take another look at the decision tree edge case fixes. --- If your project is set up for it, you can reply to this em

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-23 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 ping @jkbradley would you be able to take a look at the decision tree fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-17 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 ping @jkbradley would you be able to take a look at the decision tree fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-11 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16377 This LGTM, thanks! ping @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-11 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 ping @sethah can you please take another look at the decision tree/random forest fixes? Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71222/ Test PASSed. ---

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #71222 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71222/testReport)** for PR 16377 at commit [`f4fa050`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71221/ Test PASSed. ---

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #71221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71221/testReport)** for PR 16377 at commit [`134a764`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #71222 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71222/testReport)** for PR 16377 at commit [`f4fa050`](https://github.com/apache/spark/commit/f4

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #71221 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71221/testReport)** for PR 16377 at commit [`134a764`](https://github.com/apache/spark/commit/13

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-10 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 ping @sethah can you please take another look at the decision tree/random forest fixes? Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71155/ Test PASSed. ---

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #71155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71155/testReport)** for PR 16377 at commit [`48fb6ee`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #71155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71155/testReport)** for PR 16377 at commit [`48fb6ee`](https://github.com/apache/spark/commit/48

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-09 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 ping @sethah can you please take another look at the decision tree/random forest fixes? Thank you! --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70945/ Test PASSed. ---

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #70945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70945/testReport)** for PR 16377 at commit [`55b3171`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70944/ Test PASSed. ---

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #70944 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70944/testReport)** for PR 16377 at commit [`59e931c`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #70945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70945/testReport)** for PR 16377 at commit [`55b3171`](https://github.com/apache/spark/commit/55

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #70944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70944/testReport)** for PR 16377 at commit [`59e931c`](https://github.com/apache/spark/commit/59

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2017-01-05 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 @sethah I've updated the code based on your comments, please take a look, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-29 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 ping @sethah --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-27 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 @sethah would you be able to take a look at the proposed changes? Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16377 It's best to see who wrote the code that you're changing to ask for a review -- @sethah I think? at least Github indicates as much --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-27 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 Is there anything I need to do to allow this fix to be pushed to the base branch? Are there any pending questions/comments that still need to resolved? Thank you, Ilya --- If your projec

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70521/ Test PASSed. ---

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #70521 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70521/testReport)** for PR 16377 at commit [`ffe75e3`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16377 **[Test build #70521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70521/testReport)** for PR 16377 at commit [`ffe75e3`](https://github.com/apache/spark/commit/ff

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-22 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16377 Jenkins add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-22 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 How can I run the build/tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-22 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-21 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16377 For the reviewer: does it make sense to choose an arbitrary split with invalid gain instead of throwing an exception? It seemed like a better approach to take than to throw, since decision tr

[GitHub] spark issue #16377: [SPARK-18036][ML][MLLIB] Fixing decision trees handling ...

2016-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16377 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat