Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16639
I merged this into master. Thanks @squito!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73784/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #73784 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73784/testReport)**
for PR 16639 at commit
[`965506a`](https://github.com/apache/spark/commit/9
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16639
@squito It looks good to me, thanks for the changes !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #73784 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73784/testReport)**
for PR 16639 at commit
[`965506a`](https://github.com/apache/spark/commit/96
Github user squito commented on the issue:
https://github.com/apache/spark/pull/16639
@mridulm look ok to you too? I plan on merging soon.
I just made a small change to the comments (I copied and pasted incorrect
comments in the last test case I added)
---
If your project i
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73607/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #73607 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73607/testReport)**
for PR 16639 at commit
[`ad47611`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73597/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #73597 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73597/testReport)**
for PR 16639 at commit
[`bee5621`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #73607 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73607/testReport)**
for PR 16639 at commit
[`ad47611`](https://github.com/apache/spark/commit/ad
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16639
Jenkins retest this please (filed
https://issues.apache.org/jira/browse/SPARK-19772)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #73598 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73598/testReport)**
for PR 16639 at commit
[`ad47611`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73598/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #73598 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73598/testReport)**
for PR 16639 at commit
[`ad47611`](https://github.com/apache/spark/commit/ad
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #73597 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73597/testReport)**
for PR 16639 at commit
[`bee5621`](https://github.com/apache/spark/commit/be
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72900/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #72900 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72900/testReport)**
for PR 16639 at commit
[`7840480`](https://github.com/apache/spark/commit/7
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #72900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72900/testReport)**
for PR 16639 at commit
[`7840480`](https://github.com/apache/spark/commit/78
Github user squito commented on the issue:
https://github.com/apache/spark/pull/16639
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72882/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #72882 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72882/testReport)**
for PR 16639 at commit
[`08491c5`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72883/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #72883 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72883/testReport)**
for PR 16639 at commit
[`7840480`](https://github.com/apache/spark/commit/7
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #72883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72883/testReport)**
for PR 16639 at commit
[`7840480`](https://github.com/apache/spark/commit/78
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #72882 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72882/testReport)**
for PR 16639 at commit
[`08491c5`](https://github.com/apache/spark/commit/08
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16639
Ok I'm convinced re: not walking up the cause tree. I didn't think about
that finally case. I'll do another review now.
Re: larger integration test, I didn't have a particular thing
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16639
Walking up a getCause tree is not reliable - finally is one of the cases
where it will fail (others being catch block's ignoring it, catch-rethrow
idioms resulting in other exceptions being thrown,
Github user squito commented on the issue:
https://github.com/apache/spark/pull/16639
> (1) Instead of this approach, did you consider walking through the
exceptions (with getCause()) to see if there's a nested FetchFailure in there?
That seems simpler, with the con of missing scenari
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71673/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71673 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71673/testReport)**
for PR 16639 at commit
[`4494673`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71673 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71673/testReport)**
for PR 16639 at commit
[`4494673`](https://github.com/apache/spark/commit/44
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71668/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71668 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71668/testReport)**
for PR 16639 at commit
[`bbef893`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71669/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71669 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71669/testReport)**
for PR 16639 at commit
[`730fd83`](https://github.com/apache/spark/commit/7
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71669 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71669/testReport)**
for PR 16639 at commit
[`730fd83`](https://github.com/apache/spark/commit/73
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71668 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71668/testReport)**
for PR 16639 at commit
[`bbef893`](https://github.com/apache/spark/commit/bb
Github user squito commented on the issue:
https://github.com/apache/spark/pull/16639
thanks for the feedback @mridulm , all good points. I pushed an update to
address some of the points, also have some follow up discussion
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71640/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71640 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71640/testReport)**
for PR 16639 at commit
[`9635980`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71638 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71638/testReport)**
for PR 16639 at commit
[`b93c37f`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71638/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71640 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71640/testReport)**
for PR 16639 at commit
[`9635980`](https://github.com/apache/spark/commit/96
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71637 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71637/testReport)**
for PR 16639 at commit
[`5c28b62`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71637/
Test FAILed.
---
Github user squito commented on the issue:
https://github.com/apache/spark/pull/16639
cc @kayousterhout @markhamstra @mateiz
This isn't just protecting against crazy user code -- I've seen users hit
this with spark sql (because of
https://github.com/apache/spark/blob/278fa1e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71636/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71638 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71638/testReport)**
for PR 16639 at commit
[`b93c37f`](https://github.com/apache/spark/commit/b9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71637 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71637/testReport)**
for PR 16639 at commit
[`5c28b62`](https://github.com/apache/spark/commit/5c
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16639
**[Test build #71636 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71636/testReport)**
for PR 16639 at commit
[`0091aba`](https://github.com/apache/spark/commit/00
69 matches
Mail list logo
