Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16675
LGTM, merged into master and branch-2.1. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16675
@yanboliang Thanks. Seems to have passed tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16675
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16675
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71820/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16675
**[Test build #71820 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71820/testReport)**
for PR 16675 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16675
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71819/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16675
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16675
**[Test build #71819 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71819/testReport)**
for PR 16675 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16675
Looks good, I'll merge if it passes test. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16675
@yanboliang Thanks for the quick response. How about the new commit, where
I just change the value from `getFamily` to lower case when necessary, i.e., in
the calculation of p-value and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16675
**[Test build #71820 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71820/testReport)**
for PR 16675 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16675
@actuaryzhang I think the change is not appropriate, the function
```getFamily``` should return the raw value that users specified, this is the
cause that I didn't change them in #16516 .
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16675
I would prefer that `getFamily` returns lower case values directly, because
using `getFamily.toLowerCase` can get very cumbersome and I use this a lot in
another PR #16344. If we want to keep
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16675
**[Test build #71819 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71819/testReport)**
for PR 16675 at commit
14 matches
Mail list logo
