[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

2017-02-06 Thread kayousterhout
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/16738 Merged this to master. Thanks for the fix @jinxing64 -- these fixes to improve readability / usability of the code are super useful! --- If your project is set up for it, you can reply to th

[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

2017-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16738 **[Test build #3556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3556/testReport)** for PR 16738 at commit [`a2cfd69`](https://github.com/apache/spark/commit/

[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

2017-02-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16738 **[Test build #3556 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3556/testReport)** for PR 16738 at commit [`a2cfd69`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

2017-02-05 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16738 @kayousterhout Thanks a lot again : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

2017-02-05 Thread kayousterhout
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/16738 LGTM! Thanks for fixing this! I'll merge this tomorrow once tests pass and pending any further comments from @srowen --- If your project is set up for it, you can reply to this email and ha

[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

2017-02-05 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16738 @kayousterhout Thanks a lot for helping this pr thus far. I think the proposal is quite clear. I've already refined. Please take another look. --- If your project is set up for it, you can r

[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

2017-02-05 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16738 Thanks a lot for the comments. Actually Im still not sure how to change this log or even just remove it. I just think the log is confusing. It is printed out every FetchFailed. Please give some su

[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

2017-02-05 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16738 The state of this change is OK, but seems to trivial. This doesn't communicate something substantially different. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

2017-02-04 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16738 I just changed the log message, but not sure if it clear enough. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

2017-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16738 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

2017-02-03 Thread kayousterhout
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/16738 I'd prefer to just change the log message and not rename successful to completed -- which I think is too ambiguous with tasks that have "completed" in the sense that they've failed (if we're g