[GitHub] spark issue #16738: [SPARK-19398] remove one misleading log in TaskSetManage...

2017-02-03 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16738 @kayousterhout Would you please give a look at this ? It's great if you could help review this : ) --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark issue #16738: [SPARK-19398] remove one misleading log in TaskSetManage...

2017-02-02 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16738 @srowen Thanks a lot. I'll refine : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark issue #16738: [SPARK-19398] remove one misleading log in TaskSetManage...

2017-02-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16738 Rather than remove the comment, maybe it's better to clarify it as you say, to refer to being "completed" rather than "successful". I don't know enough to evaluate whether you're right about that cha

[GitHub] spark issue #16738: [SPARK-19398] remove one misleading log in TaskSetManage...

2017-02-01 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16738 @srowen @jasonmoore2k Thanks a lot for reviewing this PR~ >Should successful and tasksSuccessful renamed to be completed and tasksCompleted? How do you think about above and

[GitHub] spark issue #16738: [SPARK-19398] remove one misleading log in TaskSetManage...

2017-01-30 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16738 CC @jasonmoore2k for https://github.com/apache/spark/pull/12751/files#diff-bad3987c83bd22d46416d3dd9d208e76L719 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #16738: [SPARK-19398] remove one misleading log in TaskSetManage...

2017-01-29 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16738 Should `successful` and `tasksSuccessful` renamed to be `completed` and `tasksCompleted`?which I think make more sense. --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark issue #16738: [SPARK-19398] remove one misleading log in TaskSetManage...

2017-01-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16738 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat