Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16751
Hi, @robbinspg and @srowen .
Could you review the PR #16795 for that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16751
Pardon me, but is there anywhere else keeping track of the build break with
SBT? It's been failing for a while in master:
Github user robbinspg commented on the issue:
https://github.com/apache/spark/pull/16751
Sorry, I've been away for the w/end. Yes we use maven for our test runs.
Looks like you have it under control.
Thanks
---
If your project is set up for it, you can reply to this email and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16751
Ur, I reproduce that with maven test.
It's about test dependency on `parquet-avro` which now depends on
`org.apache.avro` 1.8.0.
---
If your project is set up for it, you can reply to
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16751
BTW, is there any condition to reproduce that? At least, `sbt` seems not to
complain like that.
```
$ build/sbt "project sql" "test-only *.ParquetAvroCompatibilitySuite"
...
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16751
Thank you for informing that, @robbinspg .
Could you make a JIRA issue to keep track?
I'll investigate there.
---
If your project is set up for it, you can reply to this email and
Github user robbinspg commented on the issue:
https://github.com/apache/spark/pull/16751
Since this commit our test runs are failing with
ParquetAvroCompatibilitySuite:
*** RUN ABORTED ***
java.lang.NoClassDefFoundError: org/apache/avro/LogicalType
at
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16751
Hi, @rxin .
Sure, I'll try to put them in a single PR except the ongoing one.
BTW, every time, I noticed that committers have a better and broader
perspective than me.
Do you have
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16751
can you put rest of the cleanups in one place?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16751
Ya, @mallman .
However, with the same reason, I conclude to put them away from here.
Exactly, the opposite direction of your opinion. If we try to fix all of them
in a single shot,
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16751
FYI, there are at least two workarounds in the Spark codebase which can
potentially be removed as a consequence of this upgrade. For example:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16751
Thank you for review and merging, @viirya , @srowen , and @rxin !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16751
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72191/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16751
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16751
**[Test build #72191 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72191/testReport)**
for PR 16751 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16751
Merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16751
LGTM too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16751
The dependency change looks clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16751
**[Test build #72191 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72191/testReport)**
for PR 16751 at commit
19 matches
Mail list logo
