Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16757
It had a merge conflict, so I opened:
https://github.com/apache/spark/pull/16843
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16757
This was merged to master only right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72526/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72526 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72526/testReport)**
for PR 16757 at commit
[`29c4696`](https://github.com/apache/spark/commit/2
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16757
Merging this to master/2.1/2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72521/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72521 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72521/testReport)**
for PR 16757 at commit
[`29c4696`](https://github.com/apache/spark/commit/2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72526 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72526/testReport)**
for PR 16757 at commit
[`29c4696`](https://github.com/apache/spark/commit/29
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72520 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72520/testReport)**
for PR 16757 at commit
[`23743e1`](https://github.com/apache/spark/commit/2
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16757
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72520/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72521 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72521/testReport)**
for PR 16757 at commit
[`29c4696`](https://github.com/apache/spark/commit/29
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16757
LGTM except one minor comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72520 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72520/testReport)**
for PR 16757 at commit
[`23743e1`](https://github.com/apache/spark/commit/23
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72374/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72374 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72374/testReport)**
for PR 16757 at commit
[`acbb9e0`](https://github.com/apache/spark/commit/a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72374 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72374/testReport)**
for PR 16757 at commit
[`acbb9e0`](https://github.com/apache/spark/commit/ac
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16757
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72372/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72372 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72372/testReport)**
for PR 16757 at commit
[`acbb9e0`](https://github.com/apache/spark/commit/a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72372 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72372/testReport)**
for PR 16757 at commit
[`acbb9e0`](https://github.com/apache/spark/commit/ac
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16757
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72323/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72323 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72323/testReport)**
for PR 16757 at commit
[`acbb9e0`](https://github.com/apache/spark/commit/a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72323 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72323/testReport)**
for PR 16757 at commit
[`acbb9e0`](https://github.com/apache/spark/commit/ac
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16757
The new `RemoveRedundantAliases` rule looks convoluted, is it possible to
implement an O(1) complex `isParent` method on `TreeNode`? that could make the
logic much simpler.
---
If your project i
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16757
I do not explicitly implement 'traversing the parent tree'. I have opened
up a few methods in `TreeNode` and `QueryPlan` so you can write your own
(recursive) tree traversal. In this case this al
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16757
> This PR fixes these problems by using a blacklist for attributes that are
not to be moved, and by making sure that attribute remapping is only done for
the parent tree, and not for unrelated par
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72248/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72248 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72248/testReport)**
for PR 16757 at commit
[`81f2fa5`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72248 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72248/testReport)**
for PR 16757 at commit
[`81f2fa5`](https://github.com/apache/spark/commit/81
38 matches
Mail list logo
