Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
Thank you @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16777
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16777
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72819/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72819 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72819/testReport)**
for PR 16777 at commit
[`98b46af`](https://github.com/apache/spark/commit/9
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
(I just rebased and added `private[analysis]` for consistency)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72819 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72819/testReport)**
for PR 16777 at commit
[`98b46af`](https://github.com/apache/spark/commit/98
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
@gatorsmile, Can we make this merged and then add test cases for them
separately? It seems the results are the same. I ran two tests as below:
```scala
val integralTypes =
Inde
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
I see what you mean. The code paths are now different. Let me try to
investigate it and split them.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16777
Yeah, the first PR is for refactoring and cleaning up
`findWiderTypeForTwo`. We need to add the test cases for the behavior changes.
We might also need to document this in the release note, becau
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
Do you mean two PRs for cleaning up the logics here and the support of
array type coercion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16777
I think we need to separate the changes from the support of `Type coercion
between ArrayTypes`? Could you submit another PR at first? We might need extra
test cases for this change.
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72782/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72782 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72782/testReport)**
for PR 16777 at commit
[`510a0ee`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72781/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72781 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72781/testReport)**
for PR 16777 at commit
[`c961270`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72779/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72779 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72779/testReport)**
for PR 16777 at commit
[`768c7e4`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72777/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72777 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72777/testReport)**
for PR 16777 at commit
[`31d3163`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72780/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72780 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72780/testReport)**
for PR 16777 at commit
[`5990f6f`](https://github.com/apache/spark/commit/5
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72782 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72782/testReport)**
for PR 16777 at commit
[`510a0ee`](https://github.com/apache/spark/commit/51
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72781 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72781/testReport)**
for PR 16777 at commit
[`c961270`](https://github.com/apache/spark/commit/c9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72780 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72780/testReport)**
for PR 16777 at commit
[`5990f6f`](https://github.com/apache/spark/commit/59
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72779 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72779/testReport)**
for PR 16777 at commit
[`768c7e4`](https://github.com/apache/spark/commit/76
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
Thanks @cloud-fan for your detailed review. I will keep in mind those
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72777 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72777/testReport)**
for PR 16777 at commit
[`31d3163`](https://github.com/apache/spark/commit/31
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16777
LGTM except several minor tests about tests, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72762/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72760/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72760/testReport)**
for PR 16777 at commit
[`10afdcb`](https://github.com/apache/spark/commit/1
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72762 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72762/testReport)**
for PR 16777 at commit
[`180f3c1`](https://github.com/apache/spark/commit/18
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
@cloud-fan, I just addressed your comments and test a build with Scala 2.10.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72760/testReport)**
for PR 16777 at commit
[`10afdcb`](https://github.com/apache/spark/commit/10
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72741/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72741 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72741/testReport)**
for PR 16777 at commit
[`def432a`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72740/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72740 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72740/testReport)**
for PR 16777 at commit
[`59a1cbf`](https://github.com/apache/spark/commit/5
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72741 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72741/testReport)**
for PR 16777 at commit
[`def432a`](https://github.com/apache/spark/commit/de
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72740 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72740/testReport)**
for PR 16777 at commit
[`59a1cbf`](https://github.com/apache/spark/commit/59
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
@cloud-fan, To cut this short, it seems Postgres supports this whereas Hive
does not.
It seems we now support implicit cast between`ArrayType`s via
[SPARK-18624](https://issues.apache.o
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
**Postgres**
```
postgres=# SELECT greatest(array[1], array[0.1]);
greatest
--
{1}
(1 row)
postgres=# SELECT least(array[1], array[0.1]);
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
Let me check other DBMSs and back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16777
@HyukjinKwon are you sure this is a common behavior in databases?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
cc @cloud-fan, WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72385/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72385 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72385/testReport)**
for PR 16777 at commit
[`c1eca9d`](https://github.com/apache/spark/commit/c
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72385 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72385/testReport)**
for PR 16777 at commit
[`c1eca9d`](https://github.com/apache/spark/commit/c1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72307/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72307 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72307/testReport)**
for PR 16777 at commit
[`d187ad3`](https://github.com/apache/spark/commit/d
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72307 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72307/testReport)**
for PR 16777 at commit
[`d187ad3`](https://github.com/apache/spark/commit/d1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72290/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72290 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72290/testReport)**
for PR 16777 at commit
[`b860d25`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72290 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72290/testReport)**
for PR 16777 at commit
[`b860d25`](https://github.com/apache/spark/commit/b8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72280/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72280 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72280/testReport)**
for PR 16777 at commit
[`bd0d9f7`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72280 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72280/testReport)**
for PR 16777 at commit
[`bd0d9f7`](https://github.com/apache/spark/commit/bd
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
cc @hvanhovell, could you maybe take a look please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
73 matches
Mail list logo
