[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-17 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16785 cc @sameeragarwal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16785 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16785 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73035/ Test PASSed. ---

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16785 **[Test build #73035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73035/testReport)** for PR 16785 at commit [`278c31c`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16785 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73034/ Test PASSed. ---

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16785 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16785 **[Test build #73034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73034/testReport)** for PR 16785 at commit [`4ba93fe`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16785 **[Test build #73035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73035/testReport)** for PR 16785 at commit [`278c31c`](https://github.com/apache/spark/commit/27

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16785 **[Test build #73034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73034/testReport)** for PR 16785 at commit [`4ba93fe`](https://github.com/apache/spark/commit/4b

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16785 > this looks like a very big hammer to solve this problem. Can't we try a different approach? I think we should try to avoid optimizing already optimized code snippets, you might be able to do th

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-10 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16785 @cloud-fan yeah, i agreed with you and @hvanhovell. For too slow constraint propagation, except for attacking `getAliasedConstraints` like this change, maybe we can have other way to improve

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16785 can we consider this in a higher-level of view instead of focusing on the method `getAliasedConstraints`? Maybe there is a way to do constraint propagation faster. --- If your project is set up

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-10 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16785 @hvanhovell Yeah, I think so. As in previous comment, I don't find a way now to improve `getAliasedConstraints` significantly by re-writing its logic without parallel collection. We may cons

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-10 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16785 @viirya this looks like a very big hammer to solve this problem. Can't we try a different approach? I think we should try to avoid optimizing already optimized code snippets, you might b

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16785 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16785 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72625/ Test PASSed. ---

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16785 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16785 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72305/ Test FAILed. ---

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16785 **[Test build #72305 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72305/testReport)** for PR 16785 at commit [`b4e514a`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16785 **[Test build #72305 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72305/testReport)** for PR 16785 at commit [`b4e514a`](https://github.com/apache/spark/commit/b4

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16785 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16785 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16785 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72303/ Test FAILed. ---

[GitHub] spark issue #16785: [SPARK-19443][SQL] The function to generate constraints ...

2017-02-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16785 **[Test build #72303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72303/testReport)** for PR 16785 at commit [`b4e514a`](https://github.com/apache/spark/commit/b4