Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16793
Otherwise, please give me few days .. let me give a shot with `def
replace(self, to_replace, *args, **kwargs):`and see if I can resolve it if we
are okay with that although I guess pydoc will
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16793
I think the actual root cause is because we happen to allow a dictionary
for `to_replace` at the first place.
So, do you prefer to have?
```python
def replace(self,
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16793
Also the implementation doesn't match what was proposed in
https://issues.apache.org/jira/browse/SPARK-19454
Having null value as the default in a function called replace is too risky
and
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16793
Sorry I object this change. Why would we put null as the default replace
value, in a function called replace? That seems very counterintuitive and error
prone.
---
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/16793
Thanks @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/16793
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/16793
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/16793
Let me try and take a look tonight. It seems like there are some small
formatting issues still at a quick glance but I feel like this should be close.
---
If your project is set up for it, you can
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/16793
@holdenk Do you think it is realistic to see this merged into 2.2?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74163/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #74163 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74163/testReport)**
for PR 16793 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #74163 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74163/testReport)**
for PR 16793 at commit
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/16793
Jenkins retest this please (47b2f68a885b7a2fc593ac7a55cd19742016364d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74153/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #74153 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74153/testReport)**
for PR 16793 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #74153 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74153/testReport)**
for PR 16793 at commit
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/16793
Jenkins retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #74146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74146/testReport)**
for PR 16793 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74146/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #74146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74146/testReport)**
for PR 16793 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73524/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #73524 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73524/testReport)**
for PR 16793 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #73524 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73524/testReport)**
for PR 16793 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73517/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #73517 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73517/testReport)**
for PR 16793 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #73517 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73517/testReport)**
for PR 16793 at commit
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/16793
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/16793
> I think (and I could be wrong) that @nchammas was suggesting it might
make sense to have some more tests with dict, not that the other additional new
tests are bad.
I am like Python -
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/16793
cc @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72393/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72393 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72393/testReport)**
for PR 16793 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72389/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72389 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72389/testReport)**
for PR 16793 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72393/testReport)**
for PR 16793 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72392/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72392 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72392/testReport)**
for PR 16793 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72392 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72392/testReport)**
for PR 16793 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72390 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72390/testReport)**
for PR 16793 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72390/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72390 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72390/testReport)**
for PR 16793 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72389 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72389/testReport)**
for PR 16793 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72319/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72319 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72319/testReport)**
for PR 16793 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72319 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72319/testReport)**
for PR 16793 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16793
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72318/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72318 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72318/testReport)**
for PR 16793 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16793
**[Test build #72318 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72318/testReport)**
for PR 16793 at commit
58 matches
Mail list logo
