Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16860
LGTM
Merging with master
Thanks @sueann !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16860
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16860
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72607/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16860
**[Test build #72607 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72607/testReport)**
for PR 16860 at commit
[`ce8abb3`](https://github.com/apache/spark/commit/c
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16860
Try running dev/mima locally. I bet you'll have to add stuff to the
MiMaExcludes.scala file b/c of false positives.
---
If your project is set up for it, you can reply to this email and have you
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16860
Oh, the class is private already, right on. That seems OK then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16860
@srowen This actually isn't a breaking change. This is making protected
methods private within classes which cannot be extended outside of Spark. The
classes are not final, but they only provid
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16860
**[Test build #72607 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72607/testReport)**
for PR 16860 at commit
[`ce8abb3`](https://github.com/apache/spark/commit/ce
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16860
I get it, but making something less visible after it's released is also a
breaking change. Without a good reason for that we shouldn't make changes like
this.
---
If your project is set up for it,
