Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
Very thoughtful consideration. Thanks for your explanation and suggestion!
@tejasapatil what do you think? @gatorsmile @cloud-fan
---
If your project is set up for it, you can reply to
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
Very serious consideration. Thanks for your explanation and suggestion!
what do you think? @gatorsmile @cloud-fan
---
If your project is set up for it, you can reply to this email and have
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16868
>> we don't need to do check whether the targetTable.storage.locationUri is
the same with sourceTable.storage.locationUri
We should not do that check for external tables. But continue
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
Do you mean that we don't need to do check whether the
targetTable.storage.locationUri is the same with
sourceTable.storage.locationUri or not ? @tejasapatil
---
If your project is set
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16868
There are two main uses of EXTERNAL tables I am aware of:
1. Ingest data from non-hive locations into Hive tables. This can be
covered by adding test case for reading from external
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
In @tejasapatil's comment, Whether we need to be exactly the same as Hive?
@gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
I think @tejasapatil's suggestion is reasonable, because the location is
specified by users, So the sourceTable.storage.locationUri and
targetTable.storage.locationUri can be same or
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
Please add a test case based on what @tejasapatil suggested. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
I think there is no need to do this validation, because the location is
specified by users, So the targetTable.storage.lcaotionUri and
sourceTable.storage.locationUri can be same or
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16868
BTW: Hive can allow location of external table to be same as the source
table. Can you please try that ? It should work. In the test case validations I
see this check which will fail in such
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16868
You have good coverage for DDL statements. How about a test case for
reading from external table creating using the command this PR enables ?
---
If your project is set up for it, you can
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
Please update the PR description. This statement can be used for data
source tables too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16868
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72745/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16868
**[Test build #72745 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72745/testReport)**
for PR 16868 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16868
**[Test build #72745 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72745/testReport)**
for PR 16868 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16868
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
I have run test cases successfully. Please run the test cases again.Thanks
a lot! @SparkQA
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16868
OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16868
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
I have created a new PR. Please review it, Thanks! @gatorsmile @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
23 matches
Mail list logo
