[GitHub] spark issue #16888: [WIP] [SPARK-19552] [BUILD] Upgrade Netty version to 4.1...

2018-10-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16888 Agree, this can be closed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark issue #16888: [WIP] [SPARK-19552] [BUILD] Upgrade Netty version to 4.1...

2018-10-04 Thread drcrallen
Github user drcrallen commented on the issue: https://github.com/apache/spark/pull/16888 taken over by https://github.com/apache/spark/pull/19884 ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org F

[GitHub] spark issue #16888: [WIP] [SPARK-19552] [BUILD] Upgrade Netty version to 4.1...

2017-02-14 Thread a-roberts
Github user a-roberts commented on the issue: https://github.com/apache/spark/pull/16888 I'll close this one then until there ever is a need to upgrade, cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark issue #16888: [WIP] [SPARK-19552] [BUILD] Upgrade Netty version to 4.1...

2017-02-13 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16888 @a-roberts Spark doesn't use Netty's SSL handler, so it won't be a problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark issue #16888: [WIP] [SPARK-19552] [BUILD] Upgrade Netty version to 4.1...

2017-02-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16888 Are there specific benefits brought by updating to 4.1 of Netty? Netty is so core to Spark that any bug in it would be extremely difficult to debug (yes we have founds bugs in Netty and helped fix thos

[GitHub] spark issue #16888: [WIP] [SPARK-19552] [BUILD] Upgrade Netty version to 4.1...

2017-02-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16888 OK, so there isn't actually a security case here (might update the JIRA accordingly). Updating to 4.1.x seems like a fine thing to try. If you can get it to work well, great. --- If your project is