[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17152 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17152 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74169/ Test PASSed. ---

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17152 **[Test build #74169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74169/testReport)** for PR 17152 at commit [`46da41e`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17152 **[Test build #74169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74169/testReport)** for PR 17152 at commit [`46da41e`](https://github.com/apache/spark/commit/46

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17152 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17152 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74088/ Test PASSed. ---

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17152 **[Test build #74088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74088/testReport)** for PR 17152 at commit [`f487af3`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17152 **[Test build #74088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74088/testReport)** for PR 17152 at commit [`f487af3`](https://github.com/apache/spark/commit/f4

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-07 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17152 @gatorsmile @nsyca Thank you for your comments! I've added the coverage for both `CREATE OR REPLACE VIEW` and `SubqueryExpression`s. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-06 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/17152 Going back to @gatorsmile 's question, does this fix cover the scenario below? `sql("create or replace view v1 as select * from v2")` If this is an existing problem and your PR does n

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-06 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17152 Hive report the error during alter view: ``` hive> CREATE VIEW v1 AS SELECT * FROM t1; OK Time taken: 0.556 seconds hive> CREATE VIEW v2 AS SELECT * FROM v1; OK Time ta

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17152 When do other databases report this error? During view creating/alter or during view resolution? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-05 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17152 Yeah. The temporary view does not have such an issue, because we did not change it. My typo. What I mean is `CREATE OR REPLACE VIEW`. `AlterViewAsCommand` does not cover that code path.

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-03 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17152 @gatorsmile Currently we don't perform recursive resolution over a temporary view, so perhaps that won't trigger a cyclic view reference. For example: ``` scala> spark.sql("CREATE TEMPOR

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17152 Based on our current impl of view, `createOrReplaceTempView` can still trigger the cyclic view reference. Right? --- If your project is set up for it, you can reply to this email and have your r

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17152 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73854/ Test PASSed. ---

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17152 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17152 **[Test build #73854 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73854/testReport)** for PR 17152 at commit [`1bd0260`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17152 **[Test build #73854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73854/testReport)** for PR 17152 at commit [`1bd0260`](https://github.com/apache/spark/commit/1b

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

2017-03-03 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17152 cc @gatorsmile @hvanhovell @cloud-fan @nsyca --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f