Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17242
**[Test build #74650 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74650/testReport)**
for PR 17242 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17242
anyway, I will move it to optimizer in next update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17242
hmm, so you don't think canonicalizer should use this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17242
not "integration", but "move". I think this logic belongs to optimizer
instead of canonicalizer
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17242
ping @cloud-fan Except for the optimization integration, do you have more
comments on this change? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17242
@cloud-fan I would like to defer the optimization part to another PR, if
possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17242
> shouldn't we put it in optimizer?
Yes, I think we should. The new rules can be used for optimization too.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17242
> like `a + b - b` and `a` which are semantically equal
shouldn't we put it in optimizer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17242
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74321/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17242
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17242
**[Test build #74321 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74321/testReport)**
for PR 17242 at commit
11 matches
Mail list logo
