Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17264
@rxin okay!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/17264
In the future can we put the perf result in PR descriptions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17264
LGTM merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17264
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74537/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17264
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17264
**[Test build #74537 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74537/testReport)**
for PR 17264 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17264
@hvanhovell I checked all the related code and then I think this pr
includes all the place we could replace `wrap` with `wrapperFor`.
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17264
**[Test build #74537 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74537/testReport)**
for PR 17264 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17264
@maropu this looks like a nice improvement. It is an idea to check all uses
of `wrap`, and see if we can replace them by `wrapperFor`?
---
If your project is set up for it, you can reply to
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17264
Thanks for valuable comments! I'll update soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17264
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17264
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74396/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17264
**[Test build #74396 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74396/testReport)**
for PR 17264 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17264
I quickly did check performance changes;
```
public class TestGenericUDF extends GenericUDF {
@Override
public ObjectInspector initialize(ObjectInspector[] objectInspectors)
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17264
**[Test build #74396 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74396/testReport)**
for PR 17264 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17264
I'm not sure this makes sense, so could you check? cc: @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
16 matches
Mail list logo
