Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17325
The last commit passed tests, thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17325
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17325
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75272/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17325
**[Test build #75272 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75272/testReport)**
for PR 17325 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17325
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75277/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17325
**[Test build #75277 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75277/testReport)**
for PR 17325 at commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17325
test changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17325
**[Test build #75277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75277/testReport)**
for PR 17325 at commit
Github user shubhamchopra commented on the issue:
https://github.com/apache/spark/pull/17325
Thanks @kayousterhout !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17325
Left an inline comment to eliminate the brittle Thread.sleep that remains
in the test (posting here to make sure this doesn't get lost!)
---
If your project is set up for it, you can reply
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17325
**[Test build #75272 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75272/testReport)**
for PR 17325 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17325
LGTM except one minor comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user shubhamchopra commented on the issue:
https://github.com/apache/spark/pull/17325
Elaborating a little more on how replication happens and what the code
change here does:
Spark executors cache a list of peers that is refreshed every 60s by
default. When replicating a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75133/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17325
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17325
**[Test build #75133 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75133/testReport)**
for PR 17325 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17325
agree with @kayousterhout , this is a bug fix, we should update the JIRA
ticket to say so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17325
**[Test build #75133 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75133/testReport)**
for PR 17325 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17325
> 1. Refreshing peer cache in the block manager before trying to
pro-actively replicate. This way the probability of replicating to a failed
executor is eliminated.
> 2. Explicitly stopping
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17325
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17325
It looks like this is actually fixing a bug in addition to updating the
test. Is it possible to write a unit test for the bug? In any case, can you
update the JIRA to describe the bug?
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17325
Jenkins, this is OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17325
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
24 matches
Mail list logo
