[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-22 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17373 Merging with master Thanks @WeichenXu123 ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #3895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3895/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #3895 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3895/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-22 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17373 Thanks! Will merge after rerunning tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17373 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17373 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80946/ Test PASSed. ---

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #80946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80946/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #80946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80946/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-21 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/17373 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #3894 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3894/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #3894 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3894/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-21 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17373 Oh OK makes sense. @WeichenXu123 could you please open a JIRA (linked from this task's JIRA) and CC @felixcheung on it? Thanks! I'll rerun tests to be safe and merge this afterwards.

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17373 We can open a JIRA to track --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-18 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/17373 @felixcheung So it do not cause bugs in sparkR, we can leave it in a separated PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-17 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17373 @felixcheung How will this affect ```spark.mlp``` in R? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17373 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80762/ Test PASSed. ---

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #80762 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80762/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17373 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #80762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80762/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-16 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17373 Thinking more about the proposal about separating the classification-specific logic out of the generic Topology, it's something we should definitely do at some point, but I'm OK with leaving it

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17373 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17373 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80689/ Test PASSed. ---

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #80689 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80689/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #80689 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80689/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-15 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/17373 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17373 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17373 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80684/ Test FAILed. ---

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #80684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80684/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17373 **[Test build #80684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80684/testReport)** for PR 17373 at commit

[GitHub] spark issue #17373: [SPARK-12664][ML] Expose probability in mlp model

2017-08-15 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/17373 cc @jkbradley Code updated, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature