Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17458
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17458
**[Test build #3619 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3619/testReport)**
for PR 17458 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17458
It looks good to me too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17458
**[Test build #3619 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3619/testReport)**
for PR 17458 at commit
Github user dbolshak commented on the issue:
https://github.com/apache/spark/pull/17458
Corrected.
Please take a look.
There is only one change (in 2 places) related to calling toSeq which has
comment, but it's not clear can I leave my change or not.
---
If your project is
Github user dbolshak commented on the issue:
https://github.com/apache/spark/pull/17458
@srowen, @HyukjinKwon could you please merge the PR if it's ok of course?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dbolshak commented on the issue:
https://github.com/apache/spark/pull/17458
Looks like all comments have been addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dbolshak commented on the issue:
https://github.com/apache/spark/pull/17458
@HyukjinKwon could you please explain how to request to merge the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17458
They are suggestions in my point of view. it doesn't necessarily mean you
should follow if there are some reasons.
---
If your project is set up for it, you can reply to this email and have
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17458
Probably, I guess this should be fine. Just in my experience, IntelliJ's
inspection was quite okay except the case of breaking Scala 2.10. It might be
better if they can be manually tested via
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17458
There're many changes related to UI part, actually we don't have many unit
tests covered in this part, so I'm afraid these change may potentially
introduce regression.
---
If your project is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17458
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
12 matches
Mail list logo
