[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-10 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17574 BTW making it `compile` scope means it is still also in `test` scope, which is fine. I actually don't see `xbean` as a transitive dependency otherwise? at least from Maven and SBT as best I know

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17574 Meh let's not bother. There isn't any harm in the current setup since it's already a transitive dependency. Why waste time on those? --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17574 You can make a try. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17574 @gatorsmile Thanks for the search. I don't see any usage of it in `sql/core` now. It is only used in `core`, `repl`, `graphx`. So I am wondering if we can completely remove it from the dependency.

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17574 @viirya Based on the code change history, https://github.com/apache/spark/pull/13642 removed the usage of ASM in the test case `SQLMetricsSuite.scala`. Thus, it is safe to remove the test depende

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17574 Thanks! Merging to master/2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17574 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17574 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75626/ Test PASSed. ---

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17574 **[Test build #75626 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75626/testReport)** for PR 17574 at commit [`2a03188`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17574 **[Test build #75626 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75626/testReport)** for PR 17574 at commit [`2a03188`](https://github.com/apache/spark/commit/2a

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17574 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17574 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17574 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75623/ Test FAILed. ---

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17574 **[Test build #75623 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75623/testReport)** for PR 17574 at commit [`2a03188`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17574 Do we need it as a normal dependency? Looks like sql/core doesn't use it and the building works without this dependency. Sorry if I am missing something. --- If your project is set up for it, you ca

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17574 **[Test build #75623 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75623/testReport)** for PR 17574 at commit [`2a03188`](https://github.com/apache/spark/commit/2a

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17574 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17574 **[Test build #3648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3648/testReport)** for PR 17574 at commit [`2a03188`](https://github.com/apache/spark/commit/

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17574 **[Test build #3648 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3648/testReport)** for PR 17574 at commit [`2a03188`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17574 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75618/ Test FAILed. ---

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17574 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17574 **[Test build #75618 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75618/testReport)** for PR 17574 at commit [`2a03188`](https://github.com/apache/spark/commit/2a