Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17628
@ouyangxiaochen that still isn't the right regex. Maybe there are no other
instances but I'd ask for a minimal effort to find similar instances
---
If your project is set up for it, you can reply t
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17628
@srowen Do u mean that my regex can not match all variable name? because
scala's variable name can be consisted with letter|digital|_|$? I serached the
instances of `var foo="string" `with n
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17628
`"*"` does not mean what you intend -- you mean `".*"` at least, among
other things. It's maybe not worth pursuing further, but that's the kind of
quick check I'd expect when proposing to adjust one
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17628
OK, I got it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17628
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17628
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17628
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17628
**[Test build #75759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75759/testReport)**
for PR 17628 at commit
[`32b12a0`](https://github.com/apache/spark/commit/32
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17628
It is too trivial as a separate PR and I guess we don't need a JIRA for
this change. I think we should find the similar instances at least (I don't
think we want swarming PRs fixing such things)
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17628
It's always good to merge such changes into one single PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17628
**[Test build #75759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75759/testReport)**
for PR 17628 at commit
[`32b12a0`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17628
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17628
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75759/
Test PASSed.
---
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17628
OK, I'll merge such changes together into this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17628
**[Test build #75762 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75762/testReport)**
for PR 17628 at commit
[`cef0405`](https://github.com/apache/spark/commit/ce
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17628
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17628
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75762/
Test FAILed.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17628
I will be surprised if we find much more of this in current branch. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
18 matches
Mail list logo