Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17681
LGTM, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79205/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #79205 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79205/testReport)**
for PR 17681 at commit
[`257bce0`](https://github.com/apache/spark/commit/2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #79205 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79205/testReport)**
for PR 17681 at commit
[`257bce0`](https://github.com/apache/spark/commit/25
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79194/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79196/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #79196 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79196/testReport)**
for PR 17681 at commit
[`5eb9379`](https://github.com/apache/spark/commit/5
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #79194 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79194/testReport)**
for PR 17681 at commit
[`1cc5cac`](https://github.com/apache/spark/commit/1
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #79196 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79196/testReport)**
for PR 17681 at commit
[`5eb9379`](https://github.com/apache/spark/commit/5e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #79194 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79194/testReport)**
for PR 17681 at commit
[`1cc5cac`](https://github.com/apache/spark/commit/1c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79099/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #79099 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79099/testReport)**
for PR 17681 at commit
[`a779850`](https://github.com/apache/spark/commit/a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #79099 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79099/testReport)**
for PR 17681 at commit
[`a779850`](https://github.com/apache/spark/commit/a7
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
@gatorsmile @cloud-fan @HyukjinKwon Could you review this PR when you have
sometime? Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
@felixcheung Thank you very much!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78946/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78946 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78946/testReport)**
for PR 17681 at commit
[`b49280a`](https://github.com/apache/spark/commit/b
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17681
there's an issue causing `fails due to an unknown error code` - if you
haven't rebase, rebase to master should eliminate it
---
If your project is set up for it, you can reply to this email and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17681
Thank you for informing that. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
@dongjoon-hyun Thank uï¼ your suspicions about the impl of
`InMemoryCatalog `are correct.
If we add alterFunction test case in ExternalCatalogSuite that we should
impl this in both InMem
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78946 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78946/testReport)**
for PR 17681 at commit
[`b49280a`](https://github.com/apache/spark/commit/b4
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17681
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
@SparkQA Please rebuild it , Jerkins encountered some problems, all test
cases run successfully.
@gatorsmile CC
---
If your project is set up for it, you can reply to this email and hav
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78788/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78788 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78788/testReport)**
for PR 17681 at commit
[`b49280a`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78788 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78788/testReport)**
for PR 17681 at commit
[`b49280a`](https://github.com/apache/spark/commit/b4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78781/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78781 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78781/testReport)**
for PR 17681 at commit
[`98f5f00`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78781 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78781/testReport)**
for PR 17681 at commit
[`98f5f00`](https://github.com/apache/spark/commit/98
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
@SparkQA why failed, retest it please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78767 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78767/testReport)**
for PR 17681 at commit
[`16329d2`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78767/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78767 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78767/testReport)**
for PR 17681 at commit
[`16329d2`](https://github.com/apache/spark/commit/16
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78745/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78745 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78745/testReport)**
for PR 17681 at commit
[`68a9d08`](https://github.com/apache/spark/commit/6
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78745 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78745/testReport)**
for PR 17681 at commit
[`68a9d08`](https://github.com/apache/spark/commit/68
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78691/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78691 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78691/testReport)**
for PR 17681 at commit
[`6044b18`](https://github.com/apache/spark/commit/6
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
OK, I fixed the error in the test case, retest it please, Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78691 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78691/testReport)**
for PR 17681 at commit
[`6044b18`](https://github.com/apache/spark/commit/60
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
I found only one test case which name is `create temporary function with if
not exists` , but Jenkins throw me an error
`org.scalatest.exceptions.DuplicateTestNameException: Duplicate test na
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78683/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78683 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78683/testReport)**
for PR 17681 at commit
[`b787509`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78683 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78683/testReport)**
for PR 17681 at commit
[`b787509`](https://github.com/apache/spark/commit/b7
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17681
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
retest this please,Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78240/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78240 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78240/testReport)**
for PR 17681 at commit
[`f6898c4`](https://github.com/apache/spark/commit/f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17681
**[Test build #78240 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78240/testReport)**
for PR 17681 at commit
[`f6898c4`](https://github.com/apache/spark/commit/f6
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17681
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
Jenkins, please build and run test.
@gatorsmile review the added test cases,Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
please review it, Thanks @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17681
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
OK, I'll work on this PR after your PR #18142 is merged into master.
@gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
Sorry, I have not found the impl of this PR in #18142 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17681
Your issue is not resolved. That PR just changed the function registry. It
does not solve the issue you mention here.
---
If your project is set up for it, you can reply to this email and have y
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
I am sorry about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
Sorry, I have not found the impl of this PR in #18142, so it could not be
closed.
At least the file sqlbase.g4 was not modified.
---
If your project is set up for it, you can reply to t
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17681
Could we close right now if the issue is resolved somewhere?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
Since the issue is resolved, i'll close this PR later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17681
My PR is submitted. https://github.com/apache/spark/pull/18142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17681
Hi all, where are we on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
OK. After that, leave me a message, i will work on this. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17681
The implementation of function existence checking is a little bit messy. We
might need to clean up it before starting the impl of this PR.
---
If your project is set up for it, you can reply to
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17681
The proposal LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
The new synax of creating function like this `CREATE (OR REPLACE)?
TEMPORARY? FUNCTION (IF NOT EXISTS)? qualifiedName AS className=STRING (USING
resource (',' resource)*)? `
OK, let's
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
It seems more reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17681
shall we follow `CREATE VIEW` and support both `OR REPLACE` and `IF NOT
EXISTS`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
The synax of DBMS like this` CREATE OR REPLACE FUNCTION `, it means that if
function exists we will replace it, otherwise create one. But i think we'd
better not destroy the original permanen
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17681
I am not sure whether we should support it. Could you do a search which
DBMS supports it? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
I think it is necessary to support this key word in 'create [temporary]
fucntion ...' clause,
For example:
I hava an application which has three steps as follow :
1. insert into ta
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/17681
@gatorsmile CC is it reasonable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17681
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
86 matches
Mail list logo
