Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17684
it conflicts with branch 2.1, can you send a new PR? thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17684
LGTM, merging to master/2.2!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17684
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76019/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17684
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17684
**[Test build #76019 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76019/testReport)**
for PR 17684 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17684
**[Test build #76019 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76019/testReport)**
for PR 17684 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17684
LGTM except one comment.
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/17684
Thanks, done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17684
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17684
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75980/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17684
**[Test build #75980 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75980/testReport)**
for PR 17684 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17684
**[Test build #75980 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75980/testReport)**
for PR 17684 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17684
Ok, could you write a comment in the code to explain it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/17684
To always use `BigDecimal` can make code simple. However, it always create
and keep an additional object (i.e. `BigDecimal`) even if value can be fit into
long value range.
This is a design
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17684
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17684
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75941/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17684
**[Test build #75941 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75941/testReport)**
for PR 17684 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17684
**[Test build #75941 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75941/testReport)**
for PR 17684 at commit
18 matches
Mail list logo
