[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-05-01 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17715 @jkbradley Thanks for your comments. I sent #17829 to address them, please feel free to review. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/17715 LGTM. Merged into master and branch-2.2 Thanks @yanboliang for delivering this big feature which is very useful for many practical use-cases in the industry. Thanks @WeichenXu123 fo

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17715 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76223/ Test PASSed. ---

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17715 **[Test build #76223 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76223/testReport)** for PR 17715 at commit [`96fcec4`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76221/ Test PASSed. ---

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17715 **[Test build #76221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76221/testReport)** for PR 17715 at commit [`43192a4`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17715 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17715 **[Test build #76223 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76223/testReport)** for PR 17715 at commit [`96fcec4`](https://github.com/apache/spark/commit/96

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17715 **[Test build #76221 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76221/testReport)** for PR 17715 at commit [`43192a4`](https://github.com/apache/spark/commit/43

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/17715 Many use-cases are setting the bounds as a constant instead of setting each dimensional individually. Maybe we can add the following APIs. ```scala def setLowerBoundsOnIntercepts(bound: D

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-21 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17715 @dbtsai It hits [this condition](https://github.com/scalanlp/breeze/blob/master/math/src/main/scala/breeze/optimize/LBFGSB.scala#L131) and throws exception. --- If your project is set up for it

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-21 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/17715 High level questions, what happen to LBFGSB if the initial condition is out of bound? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17715 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76028/ Test PASSed. ---

[GitHub] spark issue #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17715 **[Test build #76028 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76028/testReport)** for PR 17715 at commit [`3cfd08c`](https://github.com/apache/spark/commit/3