Github user squito commented on the issue:
https://github.com/apache/spark/pull/17902
merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77750/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #77750 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77750/testReport)**
for PR 17902 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #77750 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77750/testReport)**
for PR 17902 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/17902
fair enough on jackson.
add the log for the seed please, other than that, lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17902
> do you think its important to include jackson at this level?
I wouldn't say "important", but rather that it's a nice default. Jackson
seems to be everywhere from core onwards, and even the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77651/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #77651 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77651/testReport)**
for PR 17902 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #77651 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77651/testReport)**
for PR 17902 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77617/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #77617 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77617/testReport)**
for PR 17902 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #77617 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77617/testReport)**
for PR 17902 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77561/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #77561 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77561/testReport)**
for PR 17902 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #77561 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77561/testReport)**
for PR 17902 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77433/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #77433 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77433/testReport)**
for PR 17902 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #77433 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77433/testReport)**
for PR 17902 at commit
Github user jsoltren commented on the issue:
https://github.com/apache/spark/pull/17902
Thanks @vanzin. I agree that it's tough to split up a change in such a way
that it is easy to review. This approach - intermediate diffs in one PR, and a
set of PRs for the whole feature - seems
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17902
> Earlier on you mentioned a SQL test failure workaround in your branch
That's unrelated to this change, it was a bug introduced in a separate,
completely unrelated change.
---
If your
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17902
I don't think it's worth it to call out every design decision here. The
feature set exists because it will be used by the code in the subsequent
milestones; so if reviewing this you either need a
Github user jsoltren commented on the issue:
https://github.com/apache/spark/pull/17902
> >For example, explaining why indices can take lists of elements
> ?
That was in the comment for 52ed2b4 earlier: "This is needed because some
UI types have compound keys.". I
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17902
> I'm still having a hard time visualizing what a row in the LevelDB "looks
like".
It's a key/value store, there are no "rows". The key format is explained in
the javadoc for
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/17902
Sorry I haven't had time to review this, given it's 100% new code I haven't
have time to give it a proper read through. Hopefully I can find time by end of
month (if not sooner)
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76948/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #76948 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76948/testReport)**
for PR 17902 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #76948 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76948/testReport)**
for PR 17902 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17902
Given the overwhelming interest in reviewing this code so far, I chose to
include some changes I was working on for future milestones, in order to avoid
code churn later on. These include:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76688/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #76688 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76688/testReport)**
for PR 17902 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #76688 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76688/testReport)**
for PR 17902 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17902
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17902
Hmm... I've run into these SQL test failures in my tests, and have this
workaround in my branch:
https://github.com/vanzin/spark/pull/22/files#diff-edd374dbb96bc16363b65dab1e554793R114
In
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #76605 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76605/testReport)**
for PR 17902 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76605/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #76605 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76605/testReport)**
for PR 17902 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17902
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76589/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #76589 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76589/testReport)**
for PR 17902 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17902
For context:
- Project link: https://issues.apache.org/jira/browse/SPARK-18085
- Upcoming PRs that build on this code:
https://github.com/vanzin/spark/pulls
---
If your project is set up
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17902
**[Test build #76589 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76589/testReport)**
for PR 17902 at commit
49 matches
Mail list logo
