Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/17955
I've merged this to master (2.3.0).
Thanks to everyone who helped to review. If there is additional feedback at
this point then I'll address it in a quick followup.
---
If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17955
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17955
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77850/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17955
**[Test build #77850 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77850/testReport)**
for PR 17955 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17955
**[Test build #77850 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77850/testReport)**
for PR 17955 at commit
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/17955
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17955
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77759/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17955
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17955
**[Test build #77759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77759/testReport)**
for PR 17955 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/17955
LGTM, also cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/17955
@jiangxb1987, sorry for the super long delay in addressing that latest
review comment. I've made that one change you suggested at
https://github.com/apache/spark/pull/17955#discussion_r117385673
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17955
**[Test build #77759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77759/testReport)**
for PR 17955 at commit
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/17955
I've been running some local tests of scheduler throughput to make sure
that this doesn't adversely affect performance in the processing of task
completion events (I discovered the perf. hotspot
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/17955
at a high level this definitely makes sense. I need to look at in more
detail, I'll try to do that in the next day or two.
I am wondering what all testing you have done on this? have
Github user sameeragarwal commented on the issue:
https://github.com/apache/spark/pull/17955
cc @jiangxb1987 for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/17955
@JoshRosen Yes, I agree that it is orthogonal -- at least for now. I'm
mostly just offering a heads up that if we get around to addressing
`interruptThread`, then there may also need to be some
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/17955
@markhamstra, I think that the the `interruptThread = true` hardcoding may
be orthogonal to this PR's proposed changes: `interruptThread` affects how we
carry out task cancellation, not whether
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/17955
I've looked at only the DAGScheduler changes so far. They LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/17955
@JoshRosen The hard coding of interruptThread = true within
TaskSetManager's handleSuccessfulTask to effect the killing of duplicate,
speculative attempts of a task is potentially an issue --
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17955
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17955
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76886/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17955
**[Test build #76886 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76886/testReport)**
for PR 17955 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17955
**[Test build #76886 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76886/testReport)**
for PR 17955 at commit
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/17955
The `MapOutputTrackerSuite` `remote fetch` test case failed as of that last
commit because I didn't faithfully replicate the behavior of `clearEpoch()` /
`incrementEpoch()`.
In the old
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17955
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76838/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17955
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17955
**[Test build #76838 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76838/testReport)**
for PR 17955 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17955
**[Test build #76838 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76838/testReport)**
for PR 17955 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17955
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17955
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76836/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17955
**[Test build #76836 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76836/testReport)**
for PR 17955 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17955
**[Test build #76836 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76836/testReport)**
for PR 17955 at commit
32 matches
Mail list logo
