[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-25 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18025 since this is a fairly big change to the documentation could you please open a JIRA? this is also how we could track this work against SPARK-18825 --- If your project is set up for it, you can

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77343/ Test FAILed. ---

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18025 **[Test build #77343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77343/testReport)** for PR 18025 at commit

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77341/ Test FAILed. ---

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18025 **[Test build #77341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77341/testReport)** for PR 18025 at commit

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-24 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18025 @felixcheung All comments are addressed now and I think this is ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-24 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18025 - New commit now resolves the Name issue. `@title` does not work, which is the header in the second line `\title{Aggregate functions for Column operations}`. The solution is to use `@name

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18025 **[Test build #77341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77341/testReport)** for PR 18025 at commit

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18025 re: title, would explicitly adding `@title` help? re: multiple class - agreed, a link or `@seealso` should be good. wouldn't `?coalesce` show the overloads though --- If your project is

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-24 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18025 @felixcheung - The links to `stddev_samp` etc are already removed in the latest commit. - About collecting all the example into one, I think that'll work for this particular one. But

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18025 also, since we have an Rd now what you think about collecting all the example into one - that should eliminate all the `Not run` in every other line. I think then also this will be a

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18025 I guess we don't need link to stddev_samp since it's the same page shouldn't std_dev and var_samp also on this page? --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18025 I think we need to give it a title explicitly - see the header/first line of https://cloud.githubusercontent.com/assets/11082368/26429381/64dd117e-409b-11e7-9661-659b5fbe8206.png --- If your

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77318/ Test PASSed. ---

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18025: [WIP][SparkR] Grouped documentation for sql functions

2017-05-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18025 **[Test build #77318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77318/testReport)** for PR 18025 at commit