[GitHub] spark issue #18042: [SPARK-20817][core] Fix to return "Unknown processor" on...

2017-06-23 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18042 Please let's not waste more time here. I don't think the gain is worth the effort required (or even the discussions here). --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #18042: [SPARK-20817][core] Fix to return "Unknown processor" on...

2017-06-22 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18042 I see. I will try to use "cpu @ clock" format. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18042: [SPARK-20817][core] Fix to return "Unknown processor" on...

2017-06-22 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18042 For example, S390 appears to output "cpu, machine", not "cpu @ clock". If this is actually used by code somewhere it needs to be consistent right? if it's just for display, it's a nice-to-have, but

[GitHub] spark issue #18042: [SPARK-20817][core] Fix to return "Unknown processor" on...

2017-06-22 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18042 @srowen What do you mean "consistent"? Is it good to use a consistent format "processor identification information @ clock"? This PR make outputs of x86_64 and ppc64le similar. I could output

[GitHub] spark issue #18042: [SPARK-20817][core] Fix to return "Unknown processor" on...

2017-06-22 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18042 @kiszk unless you want to make the output of this function consistent, I'd say I'm not clear that this is a good change --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #18042: [SPARK-20817][core] Fix to return "Unknown processor" on...

2017-06-22 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18042 @srowen @rxin Do we still want this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18042: [SPARK-20817][core] Fix to return "Unknown processor" on...

2017-05-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18042 Does this really matter? I'd rather not complicate the actual code for it to display properly in some niche hardware that very few people use. --- If your project is set up for it, you can reply to

[GitHub] spark issue #18042: [SPARK-20817][core] Fix to return "Unknown processor" on...

2017-05-25 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18042 Yeah I get that, but does it cause a problem? it won't if it's just for display, but that's what I'm asking. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #18042: [SPARK-20817][core] Fix to return "Unknown processor" on...

2017-05-25 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18042 It is due to differences among CPU architectures. Here are original outputs of `/proc/info` It is used to identify CPU architecture and its model. **POWER** ``` > cat

[GitHub] spark issue #18042: [SPARK-20817][core] Fix to return "Unknown processor" on...

2017-05-25 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18042 Does it matter that the format of the output isn't quite in the same format - is it just used for display? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #18042: [SPARK-20817][core] Fix to return "Unknown processor" on...

2017-05-24 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18042 ping @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the