Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/18051
Exactly my point. Run examples internally ([it is not hard to patch
knitr](https://github.com/zero323/knitr/commit/7a0d8f9ddb9d77a9c235f25aca26131e83c1f6cc)
or even `tools::Rd2ex`) to validate
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18051
That makes sense!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18051
re: example - agreed, I think @zero323 is proposing that we only run the
example when creating the online doc, but not as CRAN (so we keep the dontrun)
---
If your project is set up for it,
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18051
@zero323 I really like your thoughts on the docs. As @felixcheung mentioned
above, we are doing some cleaning in #18025, which will improve readability and
fix the SeeAlso issue.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18051
given the work we are doing in #18025 to reorganize a lot of the pages,
this might become a very minor issue when the dust settles. So I'm good also
just to track this (wouldn't resolve the
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/18051
To be honest I thought mostly about online docs here. Duplicate links in
the bundled documentation never bothered me before (in SparkR, or any other
package for that matter) and don't I think these
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18051
hmm, so what would be the approach to fix the dup links then, change every
`@rdname` to `-method`?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/18051
If we consider improvement of the online documentation to be a separate
problem, then I fully agree with @actuaryzhang.
---
If your project is set up for it, you can reply to this email and have
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18051
Improvements to R API doc online can be useful.
But I think that is somewhat independent of this change/PR. Let's focus on
your points on `Cleaning duplicate links` and `Trying to clean see
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/18051
I think there are two different problems here:
- Quality of the internal R documentation. I think that fixing this is
non-goal. It is not only a normal state of R packages, but also
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18051
Maybe I'm missing something completely, but I still don't get the point why
we are removing the `xx-method` link since we are defining methods as S4 using
`setMethod`. Lots of packages have
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18051
@actuaryzhang - we were just talking this in the other PR. what do you
think?
@zero323 - right, I do agree `?abs-method` is kind of a big problem...
---
If your project is set up for it,
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/18051
For a moment I thought I found another solution but I was wrong.
I don't think there is a conflict between this and installable package. It
won't help with the packaged version (but other
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18051
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18051
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77207/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18051
**[Test build #77207 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77207/testReport)**
for PR 18051 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18051
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18051
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77206/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18051
**[Test build #77206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77206/testReport)**
for PR 18051 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18051
**[Test build #77207 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77207/testReport)**
for PR 18051 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18051
**[Test build #77206 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77206/testReport)**
for PR 18051 at commit
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/18051
OK, take two. Instead of modifying `00index.html`let's process `Rd` files.
This will remove `-method` aliases before html version is created.
---
If your project is set up for it, you can reply to
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18051
hmm,.. we do want people to be able to install it as a package...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/18051
It doesn't, but `R CMD build pkg` doesn't generate html index. This
happens somewhere in the `R CMD INSTALL` so even if we create custom build
script (with `devtools`), it won't helps us here.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18051
I see - I think this doesn't address doc build via `R CMD build pkg`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18051
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18051
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77156/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18051
**[Test build #77156 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77156/testReport)**
for PR 18051 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18051
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18051
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77152/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18051
**[Test build #77152 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77152/testReport)**
for PR 18051 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18051
**[Test build #77156 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77156/testReport)**
for PR 18051 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18051
**[Test build #77152 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77152/testReport)**
for PR 18051 at commit
33 matches
Mail list logo
