[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18060 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18060 **[Test build #3760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3760/testReport)** for PR 18060 at commit [`caacdc0`](https://github.com/apache/spark/commit/

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18060 **[Test build #3760 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3760/testReport)** for PR 18060 at commit [`caacdc0`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18060 **[Test build #3757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3757/testReport)** for PR 18060 at commit [`eae0f3d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18060 **[Test build #3757 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3757/testReport)** for PR 18060 at commit [`eae0f3d`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-24 Thread eatoncys
Github user eatoncys commented on the issue: https://github.com/apache/spark/pull/18060 @SparkQA Retest this please,thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-23 Thread eatoncys
Github user eatoncys commented on the issue: https://github.com/apache/spark/pull/18060 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18060 **[Test build #3750 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3750/testReport)** for PR 18060 at commit [`4c4bfbb`](https://github.com/apache/spark/commit/

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18060 **[Test build #3750 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3750/testReport)** for PR 18060 at commit [`4c4bfbb`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-23 Thread eatoncys
Github user eatoncys commented on the issue: https://github.com/apache/spark/pull/18060 @srowen Thank you for suggestion. I have validated other numerical parameters here, any other suggestion? --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18060 Yeah but maybe a good idea to valid all these aren't negative upfront. Fail faster and more consistently. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-22 Thread eatoncys
Github user eatoncys commented on the issue: https://github.com/apache/spark/pull/18060 @srowen The other parameters are validated at some other places, for example, the --executor-memory parameter is validated at org.apache.spark.memory.UnifiedMemoryManager$.getMaxMemory, the app ca

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18060 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #18060: [SPARK-20835][Core]It should exit directly when the --to...

2017-05-22 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18060 I agree it should fail faster, but shouldn't many args be validated here? CC @vanzin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.