[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-10-17 Thread bdrillard
Github user bdrillard commented on the issue: https://github.com/apache/spark/pull/18075 The second part that follows this merged PR is up as #19518. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-06-14 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18075 thanks, merging to master! you can address the remaining comments in your other PRs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18075 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78059/ Test PASSed. ---

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18075 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18075 **[Test build #78059 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78059/testReport)** for PR 18075 at commit [`678b4ad`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18075 **[Test build #78059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78059/testReport)** for PR 18075 at commit [`678b4ad`](https://github.com/apache/spark/commit/67

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-06-13 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18075 LGTM except some style comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-06-13 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18075 reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-06-12 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18075 @cloud-fan can you have a time to look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-06-12 Thread fbertsch
Github user fbertsch commented on the issue: https://github.com/apache/spark/pull/18075 We're really looking forward to this change! This bug is limiting a lot of the work we'd like to do with Spark. Any idea who we can ping to move this along? --- If your project is set up for it,

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18075 LGTM, cc @cloud-fan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread bdrillard
Github user bdrillard commented on the issue: https://github.com/apache/spark/pull/18075 The earlier failure occurred when the [`stopEarly()`](https://github.com/bdrillard/spark/blob/7fe5e4a84d4d8e71e2e63e6794e4ba13ac2e003f/sql/core/src/main/scala/org/apache/spark/sql/execution/limit.s

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18075 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77597/ Test PASSed. ---

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18075 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18075 **[Test build #77597 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77597/testReport)** for PR 18075 at commit [`7fe5e4a`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18075 **[Test build #77597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77597/testReport)** for PR 18075 at commit [`7fe5e4a`](https://github.com/apache/spark/commit/7f

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18075 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18075 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77564/ Test FAILed. ---

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18075 **[Test build #77564 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77564/testReport)** for PR 18075 at commit [`493113c`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18075 **[Test build #77564 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77564/testReport)** for PR 18075 at commit [`493113c`](https://github.com/apache/spark/commit/49

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-30 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18075 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-30 Thread bdrillard
Github user bdrillard commented on the issue: https://github.com/apache/spark/pull/18075 @ueshin As for the remaining this in `objects.scala`, https://github.com/apache/spark/pull/18075/commits/493113ce2e1271039701be35b2603271282111df#diff-e436c96ea839dfe446837ab2a3531f93L984 and t

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-25 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18075 Thanks, sound good to me for now. cc @ueshin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-23 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18075 Thank you. Absolutely, it is easier to review this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18075 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat