[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to SQLQueryT...

2017-05-24 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/18082 @gatorsmile OK,i will do,thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to SQLQueryT...

2017-05-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18082 @10110346 Could you move them to `MathExpressionsSuite`, based on @rxin 's comments? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to SQLQueryT...

2017-05-24 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18082 Hm I'm not sure if it is a good idea to run so many "unit test" style tests for expressions in the end to end suites. It takes a lot of time than just running unit tests. --- If your project is set

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to SQLQueryT...

2017-05-23 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/18082 Done. Should i delete the unit test case from `MathFunctionsSuite.scala`? @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]move test case to SQLQueryT...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18082 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this