Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18083
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77821/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77821 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77821/testReport)**
for PR 18083 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18083
LGTM except one question
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77821 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77821/testReport)**
for PR 18083 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77756/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77756 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77756/testReport)**
for PR 18083 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77758/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77758 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77758/testReport)**
for PR 18083 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77758 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77758/testReport)**
for PR 18083 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77756 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77756/testReport)**
for PR 18083 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77395/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77395 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77395/testReport)**
for PR 18083 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77395 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77395/testReport)**
for PR 18083 at commit
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/18083
Okay, I took a shot at adding timing metrics on a per-listener-class basis.
I'm not sure if my way of integrating these timers is the best, though, so
let's hold of on merging this until we've
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/18083
> I am not sure that monitoring (with real metrics) the number of dropped
events really worth it. You just want to know if messages have been dropped
(and having the number in the log is fine).
Github user bOOm-X commented on the issue:
https://github.com/apache/spark/pull/18083
I think it is quite interesting to have performance counters on the
dequeing process in the LiveListenerBus.
I am not sure that monitoring (with real metrics) the number of dropped
events
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77305/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77305 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77305/testReport)**
for PR 18083 at commit
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/18083
Context for review: a large portion of the diff in this patch was undoing
changes to the LiveListenerBus constructor and `start()` method which were
introduced in #14269. That patch introduced a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77305 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77305/testReport)**
for PR 18083 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77289/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77289/testReport)**
for PR 18083 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77277/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18083
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77277 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77277/testReport)**
for PR 18083 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18083
**[Test build #77277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77277/testReport)**
for PR 18083 at commit
33 matches
Mail list logo
