Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18114
merged to master. thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18114
This looks good to me too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78433/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #78433 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78433/testReport)**
for PR 18114 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #78433 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78433/testReport)**
for PR 18114 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18114
@HyukjinKwon Great catch. Fixed all issues you pointed out. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18114
@felixcheung, would you give me a moment to double check? I am interested
in this and want to help double check.
---
If your project is set up for it, you can reply to this email and have your
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18114
hmm, waiting for AppVeyor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18114
I think it's just the new public class detection thing that
- doesn't handle R code at all
- is confused by a code line starting with the word `class` some where
---
If your project is
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18114
@felixcheung Any idea what this message means?
`This patch adds the following public classes (experimental):
#' @Param x For class`
---
If your project is set up for it, you can reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78407/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #78407 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78407/testReport)**
for PR 18114 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #78407 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78407/testReport)**
for PR 18114 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78403/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #78403 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78403/testReport)**
for PR 18114 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18114
@felixcheung Thanks so much for the review and comments. Super helpful!
I fixed all the issues you have pointed out in the new commit.
---
If your project is set up for it, you can reply
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #78403 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78403/testReport)**
for PR 18114 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78272/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #78272 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78272/testReport)**
for PR 18114 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #78272 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78272/testReport)**
for PR 18114 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78271/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #78271 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78271/testReport)**
for PR 18114 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18114
For the `column_datetime_diff_functions`:
![image](https://user-images.githubusercontent.com/11082368/27315654-9ba01c08-552f-11e7-973e-f8351cb50aae.png)
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18114
For the date time functions, I create two groups: one for arithmetic
functions that work with two columns `column_datetime_diff_functions`, and the
other for functions that work with only one
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #78271 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78271/testReport)**
for PR 18114 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #77459 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77459/testReport)**
for PR 18114 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77459/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #77459 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77459/testReport)**
for PR 18114 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18114
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77452/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #77452 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77452/testReport)**
for PR 18114 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #77447 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77447/testReport)**
for PR 18114 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77447/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #77447 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77447/testReport)**
for PR 18114 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18114
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77441/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #77441 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77441/testReport)**
for PR 18114 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18114
@felixcheung The new commit addresses your concern by splitting methods
with two arguments into a separate doc.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #77441 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77441/testReport)**
for PR 18114 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18114
@felixcheung Thank you. This is great suggestion. I will split it into two
help files which should make the doc much cleaner without changing the
functions.
---
If your project is set up
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18114
maybe it's worthwhile to separate the dff type functions into a separate rd
so we don't have to rename/switch the parameter?
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77391/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18114
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #77391 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77391/testReport)**
for PR 18114 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18114
@felixcheung
Created this PR to update the doc for the date time methods, similar to
#18114. About 27 date time methods are documented into one page.
I'm attaching the snapshot of
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18114
**[Test build #77391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77391/testReport)**
for PR 18114 at commit
55 matches
Mail list logo