Github user liyichao commented on the issue:
https://github.com/apache/spark/pull/18144
As the idea is not that good, this is closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/18144
@cloud-fan If consistency is to remove (not add) I'm fine. Either way
consistency is the ultimate goal (as I myself am running into this discrepancy
far too often).
---
If your project is s
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18144
@jaceklaskowski This brought a lot of pain in the past(see
`functions.atan2`) and is ambiguous when a function parameter accepts both
column and string literal. If we can go back we should never
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18144
IMHO, I think we have many similar cases in `functions.scala` or other APIs
and probably we should avoid adding APIs just for consistency ...
---
If your project is set up for it, you can reply
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/18144
@cloud-fan I don't understand why would that be an issue...ever. The API is
not consistent and I often run into it.
---
If your project is set up for it, you can reply to this email and hav
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18144
I'm hesitating to add more methods with string parameters, it will blow up
the number of methods quickly...
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18144
Thanks for your work. But, I'm not 100% sure we need to make this signature
consistent with `array` and `struct`. IIUC we preferentially add these
functions in `FunctionRegistry` (users can use them
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18144
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat