Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18229
gentle ping @mkesselaers
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18229
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18229
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18229
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18229
gentle ping @mkesselaers
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18229
@mkesselaers are you still working on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/18229
I agree with changing the base 1000 to 1024. About `MiB` and `MB`, strictly
speaking, they are different. But I think in the computing technology world,
most people say Megabyte (MB) instead of
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18229
@kishorvpatil @wzhfy do you have any thoughts on this? it touches some code
you created
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18229
**[Test build #3784 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3784/testReport)**
for PR 18229 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18229
**[Test build #3784 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3784/testReport)**
for PR 18229 at commit
Github user mkesselaers commented on the issue:
https://github.com/apache/spark/pull/18229
@srowen, you're right. I changed the strings there as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18229
@mkesselaers looks like there is at least one more test testing the
formatted string that will need to be updated
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18229
**[Test build #3783 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3783/testReport)**
for PR 18229 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18229
**[Test build #3783 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3783/testReport)**
for PR 18229 at commit
Github user mkesselaers commented on the issue:
https://github.com/apache/spark/pull/18229
@srowen , I changed the variable names for `bytesToString`.
As far as I see, this should be everything.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mkesselaers commented on the issue:
https://github.com/apache/spark/pull/18229
@srowen ,
I propose to rewrite the variable names of bytesToString as well, to be
consistent.
Other occurences of KB can be found in the ivy-report.xsl and in the
ByteSuffixes of
Github user mkesselaers commented on the issue:
https://github.com/apache/spark/pull/18229
OK, the tests are fixed to take this into account.
BytesToString, now correctly output "KiB" instead of "KB" and utils.js now
also calculates the correct value.
There is still a
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18229
Those tests are wrong, in that 200 bytes is not "1953.1 KB". It is
"1953.1 KiB". And so on. The numbers should stay the same to make sure behavior
doesn't actually change, but the labels should
Github user mkesselaers commented on the issue:
https://github.com/apache/spark/pull/18229
@srowen , my apologies, I must have misunderstood you.
I changed the calculation to be MebiBytes, but afterwards saw in the tests
that the calculation was already correct
`
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18229
No, this is wrong. The function is still computing megabytes, etc.
Did you see my comment in JIRA? there is more to this change.
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18229
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
21 matches
Mail list logo
