[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-15 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18239 @cloud-fan Thanks a lot for reply. Yes, I'm also hesitate to backport branch-1.6; But I think this bug is too obvious -- with `spark.sql.adaptive.enabled=true`, any rerunning of `Shuffl

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18239 I can hardly remember the code of Spark 1.6 and I'm not sure when is the next release of the 1.6 branch. BTW this bug can be worked around by turning off `spark.sql.adaptive.enabled`, do we really

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-15 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18239 Also cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-15 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18239 In master branch, there's no such issue. I think the scenario described in jira is a good case. And I will add a test case in the pr. Our product env is based on spark-1.6. So I made this pr a

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-15 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18239 One quick question, have you tested whether the issue exists on current master branch? Could you also write a test case to cover this scenario? --- If your project is set up for it, yo

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-14 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18239 Very gentle ping @jiangxb1987 It would be great if you can take a look when you have time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-12 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18239 Just back to China, will invest in this PR tomorrow. Sorry about the delay! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-09 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18239 @jiangxb1987 would you mind to take a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18239 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18239 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77810/ Test PASSed. ---

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18239 **[Test build #77810 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77810/consoleFull)** for PR 18239 at commit [`debd107`](https://github.com/apache/spark/commit/

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18239 **[Test build #77810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77810/consoleFull)** for PR 18239 at commit [`debd107`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-08 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18239 I'm not sure if it is appropriate to make this pr and backport to 1.6. It's great if there's someone taking some time reviewing this. --- If your project is set up for it, you can reply to this e