[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-10-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18251 Sorry for the delay, pretty busy these days... I'll update this PR this week and try to merge it ASAP. --- - To unsubscribe

[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-10-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18251 @vanzin @cloud-fan if this actually does resolve the stack trace now mentioned in https://issues.apache.org/jira/browse/SPARK-21033 then I can at least vouch for this one being a problem I've hit rep

[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-10-03 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18251 ping @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-07-13 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/18251 Making `DEFAULT_NUM_ELEMENTS_FOR_SPILL_THRESHOLD` 2 times smaller may be not very well, this will increase the `spill`. Adding a safe check in ` UnsafeExternalSorter.growPointerArrayIfNecessary`

[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-06-15 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18251 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18251 also cc @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18251 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77841/ Test PASSed. ---

[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18251 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18251 **[Test build #77841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77841/testReport)** for PR 18251 at commit [`93550f4`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18251 **[Test build #77841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77841/testReport)** for PR 18251 at commit [`93550f4`](https://github.com/apache/spark/commit/93

[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18251 cc @davies @sameeragarwal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi