Github user sethah commented on the issue:
https://github.com/apache/spark/pull/18305
What's blocking us here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/18305
No blockers, I'm pretty happy. I just wanted to do a final pass mostly over
the test cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/18305
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #79962 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79962/testReport)**
for PR 18305 at commit
[`cb40b31`](https://github.com/apache/spark/commit/cb
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #79962 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79962/testReport)**
for PR 18305 at commit
[`cb40b31`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79962/
Test PASSed.
---
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/18305
Merged to master. Thanks @sethah, and thanks all for reviews.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/18305
Thanks @MLnick, @hhbyyh, and @facaiy for reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #78063 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78063/testReport)**
for PR 18305 at commit
[`6edd128`](https://github.com/apache/spark/commit/6e
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/18305
cc @VinceShieh @MLnick @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78063/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #78063 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78063/testReport)**
for PR 18305 at commit
[`6edd128`](https://github.com/apache/spark/commit/6
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #78065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78065/testReport)**
for PR 18305 at commit
[`fcf5372`](https://github.com/apache/spark/commit/fc
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78065/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #78065 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78065/testReport)**
for PR 18305 at commit
[`fcf5372`](https://github.com/apache/spark/commit/f
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/18305
also ping @hhbyyh @yanboliang This is a straightforward follow up to
https://github.com/apache/spark/pull/17094. Let me know if I can do anything to
make the review easier.
---
If your project is s
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18305
@sethah I will take a look in a few days after some backlog, thanks for
your patience.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/18305
Overall looks good, left a few comments about the reg function change and
tests for logistic agg.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #78820 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78820/testReport)**
for PR 18305 at commit
[`a19b385`](https://github.com/apache/spark/commit/a1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78820/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #78820 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78820/testReport)**
for PR 18305 at commit
[`a19b385`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #79244 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79244/testReport)**
for PR 18305 at commit
[`a51e565`](https://github.com/apache/spark/commit/a5
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #79244 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79244/testReport)**
for PR 18305 at commit
[`a51e565`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79244/
Test PASSed.
---
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/18305
I get it in source code. I'm indifferent in tests. If it's easy sure.
How does it help uncover bugs though?
On Tue, 11 Jul 2017 at 04:42, Yanbo Liang wrote:
> *@yanboliang* comme
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18305
@MLnick I remembered a bug I hit several months ago: we forgot to destroy a
broadcast variable in source code, but it throws exception after we add destroy
explicitly. This is because we put broa
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/18305
Did we reach a consensus on the broadcast variables? My opinion is that
it's probably better in this case not to worry about it, and we can back out
the change that destroys them in the test suites.
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/18305
@sethah IMO we should back out the test-related bc var explicit destroy
code as it complicates things. I hear that this _may_ help catch bugs... but
frankly I'm not convinced.
Because the co
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/18305
Thanks @MLnick. I agree with you about the broadcasting, so have backed it
out. I think all comments are addressed now, please let me know if there is
anything else.
---
If your project is set up f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #79715 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79715/testReport)**
for PR 18305 at commit
[`cb40b31`](https://github.com/apache/spark/commit/cb
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18305
**[Test build #79715 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79715/testReport)**
for PR 18305 at commit
[`cb40b31`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18305
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79715/
Test PASSed.
---
38 matches
Mail list logo